Changeset 18455 for trunk/include/functions_tag.inc.php

Timestamp:

Oct 4, 2012, 6:15:28 AM (12 years ago)

Author:

rvelices

Message:

php optimizations:

• use faster [] operator instead of array_push
• if tags are grouped by letter, don't add level to tags, sort etc ...

File:

• trunk/include/functions_tag.inc.php (modified) (4 diffs)

trunk/include/functions_tag.inc.php

@@ -65 +65 @@
   while ($row = pwg_db_fetch_assoc($result))
   {
-    $counter = @$tag_counters[ $row['id'] ];
+    $counter = intval(@$tag_counters[ $row['id'] ]);
     if ( $counter )
     {
       $row['counter'] = $counter;
       $row['name'] = trigger_event('render_tag_name', $row['name']);
-      array_push($tags, $row);
+      $tags[] = $row;
     }
   }
@@ -92 +92 @@
   {
     $row['name'] = trigger_event('render_tag_name', $row['name']);
-    array_push($tags, $row);
+    $tags[] = $row;
   }
 
@@ -139 +139 @@
 
   // display sorted tags
-  foreach (array_keys($tags) as $k)
-  {
-    $tags[$k]['level'] = 1;
+  foreach ($tags as &$tag)
+  {
+    $tag['level'] = 1;
 
     // based on threshold, determine current tag level
     for ($i = $conf['tags_levels'] - 1; $i >= 1; $i--)
     {
-      if ($tags[$k]['counter'] > $threshold_of_level[$i])
+      if ($tag['counter'] > $threshold_of_level[$i])
       {
-        $tags[$k]['level'] = $i + 1;
+        $tag['level'] = $i + 1;
         break;
       }
     }
   }
+  unset($tag);
 
   return $tags;
@@ -255 +256 @@
   {
     $row['name'] = trigger_event('render_tag_name', $row['name']);
-    array_push($tags, $row);
+    $tags[] = $row;
   }
   usort($tags, 'tag_alpha_compare');