Changeset 579 for trunk/picture.php

Timestamp:

Oct 23, 2004, 7:56:46 PM (20 years ago)

Author:

z0rglub

Message:

• refactoring of comments.php

• creation of function get_thumbnail_src used everywhere a thumbnail must be displayed

• creation of function parse_comment_content (used in comments.php and picture.php)

• concerning undefined index on arrays retrieved in database, instead of testing possibly unset values, use of @ operator (smarter...)

• add pre tag in default.css stylesheet for debugging purpose (need to have left aligned text)

File:

• trunk/picture.php (modified) (2 diffs)

trunk/picture.php

@@ -182 +182 @@
   }
 
-  if (isset($row['tn_ext']) and $row['tn_ext'] != '')
-  {
-    $picture[$i]['thumbnail'] = $cat_directory.'thumbnail/';
-    $picture[$i]['thumbnail'].= $conf['prefix_thumbnail'].$file_wo_ext;
-    $picture[$i]['thumbnail'].= '.'.$row['tn_ext'];
-  }
-  else
-  {
-    $picture[$i]['thumbnail'] = $icon;
-  }
+  $picture[$i]['thumbnail'] = get_thumbnail_src($row['file'],
+                                                $row['storage_category_id'],
+                                                @$row['tn_ext']);
   
   if ( !empty( $row['name'] ) )
@@ -962 +955 @@
   while ( $row = mysql_fetch_array( $result ) )
   {
-    $content = nl2br( $row['content'] );
-
-    // replace _word_ by an underlined word
-    $pattern = '/_([^\s]*)_/';
-    $replacement = '<span style="text-decoration:underline;">\1</span>';
-    $content = preg_replace( $pattern, $replacement, $content );
-
-    // replace *word* by a bolded word
-    $pattern = '/\*([^\s]*)\*/';
-    $replacement = '<span style="font-weight:bold;">\1</span>';
-    $content = preg_replace( $pattern, $replacement, $content );
-
-    // replace /word/ by an italic word
-    $pattern = '/\/([^\s]*)\//';
-    $replacement = '<span style="font-style:italic;">\1</span>';
-    $content = preg_replace( $pattern, $replacement, $content );
-        
-    $template->assign_block_vars('comments.comment', array(
-    'COMMENT_AUTHOR'=>empty($row['author'])?$lang['guest']:$row['author'],
-    'COMMENT_DATE'=>format_date( $row['date'], 'mysql_datetime', true ),
-        'COMMENT'=>$content
+    $template->assign_block_vars(
+      'comments.comment',
+      array(
+        'COMMENT_AUTHOR'=>empty($row['author'])?$lang['guest']:$row['author'],
+        'COMMENT_DATE'=>format_date($row['date'], 'mysql_datetime', true),
+        'COMMENT'=>parse_comment_content($row['content'])
         ));
         
     if ( $user['status'] == 'admin' )
     {
-          $template->assign_block_vars('comments.comment.delete', array('U_COMMENT_DELETE'=>add_session_id( $url.'&amp;del='.$row['id'] )));
-    }
-  }
-
-  if ( !$user['is_the_guest']||( $user['is_the_guest'] and $conf['comments_forall'] ) )
+      $template->assign_block_vars(
+        'comments.comment.delete',
+        array('U_COMMENT_DELETE'=>add_session_id( $url.'&amp;del='.$row['id'])
+          ));
+    }
+  }
+
+  if (!$user['is_the_guest']
+      or ($user['is_the_guest'] and $conf['comments_forall']))
   {
     $template->assign_block_vars('comments.add_comment', array());
     // display author field if the user is not logged in
-    if ( !$user['is_the_guest'] )
-    {
-      $template->assign_block_vars('comments.add_comment.author_known', array('KNOWN_AUTHOR'=>$user['username']));
-        }
+    if (!$user['is_the_guest'])
+    {
+      $template->assign_block_vars(
+        'comments.add_comment.author_known',
+        array('KNOWN_AUTHOR'=>$user['username'])
+        );
+    }
     else
     {
-      $template->assign_block_vars('comments.add_comment.author_field', array());
+      $template->assign_block_vars(
+        'comments.add_comment.author_field', array()
+        );
     }
   }