Piwigo.org

xbgmsharp · 2013-06-27 03:39:14

Nice.
A few comments

1- Event/Trigger for metadata. The video does not have exif metadata so the trigger is never run. The trigger should be indepedant.

2- Please don't use google map as a default map provider.

3- I don't see this mobile template in the list http://piwigo.org/bugs/view.php?id=2919

4- when doing the installation i got this error
[mysql error 1062] Duplicate entry 'elegant' for key 'PRIMARY'

INSERT INTO piwigobeta_config (param,value,comment)
VALUES ('elegant' , 'a:3:{s:11:\"p_main_menu\";s:2:\"on\";s:12:\"p_pict_descr\";s:2:\"on\";s:14:\"p_pict_comment\";s:3:\"off\";}' , 'p_main_menu#');

#1 my_error /var/www/piwigo-beta/piwigo/include/dblayer/functions_mysqli.inc.php(109)
#2 pwg_query /var/www/piwigo-beta/piwigo/themes/elegant/admin/upgrade.inc.php(17)
#3 include /var/www/piwigo-beta/piwigo/themes/elegant/themeconf.inc.php(17)
#4 include /var/www/piwigo-beta/piwigo/include/template.class.php(894)
#5 Template::load_themeconf /var/www/piwigo-beta/piwigo/include/template.class.php(141)
#6 Template::set_theme /var/www/piwigo-beta/piwigo/include/template.class.php(116)
#7 Template::Template /var/www/piwigo-beta/piwigo/include/functions_mail.inc.php(172)
#8 get_mail_template /var/www/piwigo-beta/piwigo/include/functions_mail.inc.php(593)
#9 pwg_mail /var/www/piwigo-beta/piwigo/install.php(508)

5- When i install piwigo-openstreetmap
I have an issue with query:
SELECT COUNT(*) as nb FROM INFORMATION_SCHEMA.COLUMNS WHERE TABLE_SCHEMA = DATABASE() AND TABLE_NAME = "piwigobeta_images" AND COLUMN_NAME = "lat" OR COLUMN_NAME = "lon"
Mysql return 2, but 'pwg_db_fetch_array( pwg_query($q) );' return 3
Is this a normal behavior?
I try different 'pwg_db_' and they all return 3.

6- Could we get list of function like the trigger list. Like 'conf_update_param' and all the pwg function for example.

7- Could the trigger list with more comment.

mistic100 · 2013-06-27 03:48:24

2- By default Piwigo doesn't provide any map, it's a plugin.... actually I don't undstarnd your comment you are the author of the OSM plugin

4- I think you didn't purge your database, so Piwigo tries to install on already existing tables, which fail

5- What the purpose of this query ? I'm sure there a simplier way, my advice is : never trust INFORMATION_SCHEMA table (please open a topic about that)

6- I don't see the real interest, functions are already sorted in "categories" (ie files), with Notepad++ you just have to Display->collapse all blocks to get a readable list of all functions
I already have difficulties to maintain the triggers list, undoable for functions list (it's a pity we don't use a documentation system, but it's hard work)

7- any contribution is appreciated :)

mistic100 · 2013-06-27 03:50:26

and please read this about fetch methods http://www.newgrounds.com/bbs/topic/965591
again an personal advice : never use fecth_array, it's totally useless in 99.99% cases, use fetch_assoc or fetch_row instead

plg · 2013-06-27 13:12:13

Hi xbgmsharp,

mistic100 wrote:
2- By default Piwigo doesn't provide any map, it's a plugin.... actually I don't undstarnd your comment you are the author of the OSM plugin

xbgmsharp is right, we use Google Maps in the new [Bugtracker] ticket 2885

As I said to rvelices on http://piwigo.org/bugs/view.php?id=2885#c6987 we have changed the code so that Google Maps is only loaded on explicit request by the user.

In the code, we load an img as this:

<img width=300 height=220 src="http://maps.googleapis.com/maps/api/staticmap?sensor=false&size=300x220&zoom=6&markers=size:tiny%7C" + data.latitude + "," + data.longitude + "\">"

It means we don't load the Google Maps javascript at all.

Does Open Street Map provides such a feature? If yes, I would be happy to use it instead of Google Maps.

xbgmsharp · 2013-06-28 05:24:10

plg wrote:
Hi xbgmsharp,

...
In the code, we load an img as this:

<img width=300 height=220 src="http://maps.googleapis.com/maps/api/staticmap?sensor=false&size=300x220&zoom=6&markers=size:tiny%7C" + data.latitude + "," + data.longitude + "\">"

It means we don't load the Google Maps javascript at all.

Does Open Street Map provides such a feature? If yes, I would be happy to use it instead of Google Maps.

Yes it does:
$osmlink="http://openstreetmap.org/?mlat=".$lat."&mlon=".$lon."&zoom=12&layers=M";

For me the most important point is 1.
Event/Trigger for metadata. The video does not have exif metadata so the trigger is never run. The trigger should be indepedant.

Regarding point 6,7
I thought you use some kind of documentation generator like http://apigen.org/ or http://www.docblox-project.org/
See more at http://en.wikipedia.org/wiki/Comparison … generators
Maintaining a list is definitely not ideal.
And i don't use any windows so no notepad++
The main point is to not look at the code to get to know the function like conf_update or any other.
This make third party developer easy.

mistic100 · 2013-06-28 11:47:58

1- I supposed you had a look a the code, where to add it ?

6/7 - You are right obviously and anyone know it, but, still it's a hardwork to make the whole project compatible

flop25 · 2013-06-28 11:56:15

Hi guys
just found that http://cnedelcu.net/phpdocfill/ If it reads the already existing comments that would be awesome

mistic100 · 2013-06-28 12:06:53

it's just an interface, it uses the same syntax as phpDocumentor (it's the point of any doc software to read the existing comments :-D )

flop25 · 2013-06-28 12:08:44

I've understood that but I thought it could also generate a doc from that . Maybe I'm mistaken

xbgmsharp · 2013-06-29 05:13:21

Regarding those point:

1- Event/Trigger for metadata. The video does not have exif metadata so the trigger is never run. The trigger should be indepedant.
This will improve integration for non supported format.

3- I don't see this mobile template fix in the list http://piwigo.org/bugs/view.php?id=2919
This is request by a lot of people.
http://piwigo.org/forum/viewtopic.php?id=20807
http://fr.piwigo.org/forum/viewtopic.php?id=22684
http://piwigo.org/forum/viewtopic.php?id=21984

Regarding the documentation:
Making the code ready for documentation is a must have and a one time effort.
Without a good documentation it is harder to get new contributor.

Regarding openstreetmap image, here you can find the details.
http://wiki.openstreetmap.org/wiki/Static_map_images
openstreetmap is more in the same philosophy than Piwigo.
I suggest to use mapquest.com or openstreetmap.org

Piwigo.org

Announcement

#1 2013-06-27 03:39:14

[2.6Beta1] feedback

#2 2013-06-27 03:48:24

Re: [2.6Beta1] feedback

#3 2013-06-27 03:50:26

Re: [2.6Beta1] feedback

#4 2013-06-27 13:12:13

Re: [2.6Beta1] feedback

mistic100 wrote:

#5 2013-06-28 05:24:10

Re: [2.6Beta1] feedback

plg wrote:

#6 2013-06-28 11:47:58

Re: [2.6Beta1] feedback

#7 2013-06-28 11:56:15

Re: [2.6Beta1] feedback

#8 2013-06-28 12:06:53

Re: [2.6Beta1] feedback

#9 2013-06-28 12:08:44

Re: [2.6Beta1] feedback

#10 2013-06-29 05:13:21

Re: [2.6Beta1] feedback

Board footer