Hello,

I try to modify Phpwebgallery to render it (X)HTML strict valid.

I started with version 1.4.1 on the default template to simplify the job.

I had to modify the template and also small things in the php core code
You can try it at http://droopy191.free.fr/pwg141/

The whole user-interface seems to be valid XHTML 1.0 strict (excepted 1 strange bug on thumbnail page).

Download mod source at http://droopy191.free.fr/pwg141/phpwebg … .1beta.zip

Hope to hear from PWG developpers team and/or tester.
Feel free to discuss in English or French.

Laurent


List of modifications
******************
phpwebgallery core bugs
******************
/include/functions_html.inc
line 344: function get_html_menu_category() -> modified to return valid HTML menu

******************
about.php
line 44:
not sure of what is doing ".$_SERVER['QUERY_STRING']"
result was 3 session id in returned URL with 2 & that are not escaped
removed ".$_SERVER['QUERY_STRING']" in "add_session_id(PHPWG_ROOT_PATH.'category.php?'.$_SERVER['QUERY_STRING'])"
TO BE CHECKED PWG developpers

******************
Comment.php
line 86: missing 'F_ACTION'=>add_session_id(PHPWG_ROOT_PATH.'comments.php'),

******************
profile.php
line 434: same as line 44 in about.php

******************
/language/*/admin.lang.php
line 145: character "&" not escaped
replace 'Session & Cookie' by 'Session & Cookie'

/language/*/common.lang.php
line 132 133 < and > replaced by their escaped html equivalent


******************
Problem of text with blank space in tag <a>,  it is a problem in all string used in mail subject
******************
/language/*/common.lang.php

line 290: strings used in URL blank spaces are not accepted by the Tidy validator even accepted by W3C one.
replace all " " by "%20" (blank spaces)  => '[phpwebgallery]%20une%20remarque%20sur%20ton%20site'
used in identification, about pages

insert between line 91/92 : ident_forgotten_pass_mail_subject with %20 coded mail subject
template identification.tpl and identification.php modified in accordance

******************
identification.php
insert line 80:    'L_FORGET_TEXT' => $lang['ident_forgotten_pass_mail_subject'],
see /language/fr_FR.iso-8859-1/common.lang.php modification for details

These  hacks with %20  may be replaced by an ASCII encoder function for mail subject

******************
Template
******************
many modifications: none seems to impact on the interface -> to be tested by IE user ;-)
See in archive /template/default/MODIFbyDROOPY.txt

******************
Todo list
******************
one problem identified but not solved ( I am  quite sure that is is in the php code and not the template )
On main PWG page ( thumbnail page ), when a lign is full, PWG returns an empty lign
<tr></tr>  at the end of the table ( not HTML valid )
ex: thumnail 3x3
if there are 3, 6, or 9 pictures
the html code is:
<table  class="thumbnail">
<tr> 3 td with     right parameters  </tr>
<tr> empty and useless lign </tr>
</table>
if there are 1, 2, 4 ... not a multiple of 3 pictures, the empty line does not appear.
that is not depending on which thumbnail size is selected.

admin pages

Error messages: ??