Piwigo.org

plg · 2009-01-06 22:35:27

29 files were currently not in Unix file format, I've converted them.

Code:

$ find . -type f \
  | grep -v .svn \
  | perl -ne 'END{foreach (reverse sort {$ext{$a} <=> $ext{$b}} keys %ext) {printf("%10s : %u\n", $_, $ext{$_})}} chomp; if (m{/.*?\.([^\.]+)$}){$ext{$1}++}'
       php : 459
       png : 195
      html : 123
       tpl : 110
        js : 85
       gif : 62
       css : 35
       txt : 8
       jpg : 5
       htc : 3
        pl : 2
       sql : 2
 cvsignore : 1
       htm : 1
       lib : 1
        sh : 1
    readme : 1
       ico : 1

Code:

[pierrick@plegall] /tmp/20
$ for ext in htc css readme txt php html sh sql htm pl tpl js; do   find . -name "*.$ext"; done | xargs -i dos2unix {}

Code:

$ svn st
M      language/it_IT/help/cat_modify.html
M      language/it_IT/help/advanced_feature.html
M      language/it_IT/help/notification_by_mail.html
M      language/it_IT/help/maintenance.html
M      language/it_IT/help/cat_options.html
M      language/it_IT/help/thumbnail.html
M      language/it_IT/help/group_list.html
M      language/it_IT/help/index.php
M      language/it_IT/help/cat_perm.html
M      language/it_IT/help/cat_move.html
M      language/it_IT/help/site_manager.html
M      language/it_IT/help/history.html
M      language/it_IT/help/search.html
M      language/it_IT/help/permalinks.html
M      language/it_IT/help/configuration.html
M      language/it_IT/help/user_list.html
M      language/it_IT/help/synchronize.html
M      language/it_IT/help.html
M      language/it_IT/install.lang.php
M      language/it_IT/about.html
M      language/it_IT/admin.lang.php
M      language/it_IT/common.lang.php
M      plugins/add_index/admin/main_page.php
M      plugins/c13y_upgrade/initialize.inc.php
M      plugins/c13y_upgrade/main.inc.php
M      admin/template/goto/history.tpl
M      install/db/33-database.php
M      install/db/61-database.php
M      install/db/37-database.php

This is my commit [Subversion] r3054

Please try to be careful, there should only remain Unix file format.

VDigital · 2009-01-06 22:45:46

Win users have to take care of this point...
Thxs.

rvelices · 2009-01-06 23:23:28

z0rglub wrote:
Please try to be careful, there should only remain Unix file format.

It is better to set the svn line style property to LF. In this case you don't have to worry anymore about line formats and you can use whatever Windows editor wether it handles or not Unix style line feeds ...

plg · 2009-01-07 01:11:35

Thank you rvelices. Rub has send me an email to tell me exactly the same thing.

Code:

[pierrick@plegall] /tmp/20
$ for ext in htc css readme txt php html sh sql htm pl tpl js; do   find . -name "*.$ext"; done | perl -ne 'chomp; $prop=`svn propget svn:eol-style $_`; chomp $prop; if ($prop ne "LF"){printf("svn propset svn:eol-style \"LF\" %s\n", $_)}'
svn propset svn:eol-style "LF" ./tools/release_creation.readme
svn propset svn:eol-style "LF" ./language/it_IT/iso.txt
svn propset svn:eol-style "LF" ./include/functions_mail.inc.php
svn propset svn:eol-style "LF" ./include/class_smtp_mail.inc.php
svn propset svn:eol-style "LF" ./include/ws_protocols/index.php
svn propset svn:eol-style "LF" ./include/php_compat/index.php
svn propset svn:eol-style "LF" ./admin/element_set_ranks.php
svn propset svn:eol-style "LF" ./language/it_IT/install.lang.php
svn propset svn:eol-style "LF" ./language/it_IT/common.lang.php
svn propset svn:eol-style "LF" ./language/it_IT/admin.lang.php
svn propset svn:eol-style "LF" ./language/it_IT/help/index.php
svn propset svn:eol-style "LF" ./language/it_IT/index.php
svn propset svn:eol-style "LF" ./plugins/c13y_upgrade/initialize.inc.php
svn propset svn:eol-style "LF" ./plugins/c13y_upgrade/main.inc.php
svn propset svn:eol-style "LF" ./plugins/add_index/admin/main_page.php
svn propset svn:eol-style "LF" ./install/db/37-database.php
svn propset svn:eol-style "LF" ./install/db/78-database.php
svn propset svn:eol-style "LF" ./install/db/33-database.php
svn propset svn:eol-style "LF" ./install/db/76-database.php
svn propset svn:eol-style "LF" ./install/db/79-database.php
svn propset svn:eol-style "LF" ./install/db/61-database.php
svn propset svn:eol-style "LF" ./language/it_IT/help/history.html
svn propset svn:eol-style "LF" ./language/it_IT/help/cat_options.html
svn propset svn:eol-style "LF" ./language/it_IT/help/configuration.html
svn propset svn:eol-style "LF" ./language/it_IT/help/maintenance.html
svn propset svn:eol-style "LF" ./language/it_IT/help/site_manager.html
svn propset svn:eol-style "LF" ./language/it_IT/help/search.html
svn propset svn:eol-style "LF" ./language/it_IT/help/permalinks.html
svn propset svn:eol-style "LF" ./language/it_IT/help/group_list.html
svn propset svn:eol-style "LF" ./language/it_IT/help/cat_move.html
svn propset svn:eol-style "LF" ./language/it_IT/help/advanced_feature.html
svn propset svn:eol-style "LF" ./language/it_IT/help/notification_by_mail.html
svn propset svn:eol-style "LF" ./language/it_IT/help/user_list.html
svn propset svn:eol-style "LF" ./language/it_IT/help/synchronize.html
svn propset svn:eol-style "LF" ./language/it_IT/help/cat_perm.html
svn propset svn:eol-style "LF" ./language/it_IT/help/thumbnail.html
svn propset svn:eol-style "LF" ./language/it_IT/help/cat_modify.html
svn propset svn:eol-style "LF" ./language/it_IT/about.html
svn propset svn:eol-style "LF" ./language/it_IT/help.html
svn propset svn:eol-style "LF" ./admin/template/goto/history.tpl
svn propset svn:eol-style "LF" ./template/yoga/calendar_navbar.tpl

Code:

[pierrick@plegall] /tmp/20
$ for ext in htc css readme txt php html sh sql htm pl tpl js; do   find . -name "*.$ext"; done | perl -ne 'chomp; $prop=`svn propget svn:eol-style $_`; chomp $prop; if ($prop ne "LF"){printf("svn propset svn:eol-style \"LF\" %s\n", $_)}' \
  bash
property 'svn:eol-style' set on 'tools/release_creation.readme'
property 'svn:eol-style' set on 'language/it_IT/iso.txt'
property 'svn:eol-style' set on 'include/functions_mail.inc.php'
property 'svn:eol-style' set on 'include/class_smtp_mail.inc.php'
property 'svn:eol-style' set on 'include/ws_protocols/index.php'
property 'svn:eol-style' set on 'include/php_compat/index.php'
property 'svn:eol-style' set on 'admin/element_set_ranks.php'
property 'svn:eol-style' set on 'language/it_IT/install.lang.php'
property 'svn:eol-style' set on 'language/it_IT/common.lang.php'
property 'svn:eol-style' set on 'language/it_IT/admin.lang.php'
property 'svn:eol-style' set on 'language/it_IT/help/index.php'
property 'svn:eol-style' set on 'language/it_IT/index.php'
property 'svn:eol-style' set on 'plugins/c13y_upgrade/initialize.inc.php'
property 'svn:eol-style' set on 'plugins/c13y_upgrade/main.inc.php'
property 'svn:eol-style' set on 'plugins/add_index/admin/main_page.php'
property 'svn:eol-style' set on 'install/db/37-database.php'
property 'svn:eol-style' set on 'install/db/78-database.php'
property 'svn:eol-style' set on 'install/db/33-database.php'
property 'svn:eol-style' set on 'install/db/76-database.php'
property 'svn:eol-style' set on 'install/db/79-database.php'
property 'svn:eol-style' set on 'install/db/61-database.php'
property 'svn:eol-style' set on 'language/it_IT/help/history.html'
property 'svn:eol-style' set on 'language/it_IT/help/cat_options.html'
property 'svn:eol-style' set on 'language/it_IT/help/configuration.html'
property 'svn:eol-style' set on 'language/it_IT/help/maintenance.html'
property 'svn:eol-style' set on 'language/it_IT/help/site_manager.html'
property 'svn:eol-style' set on 'language/it_IT/help/search.html'
property 'svn:eol-style' set on 'language/it_IT/help/permalinks.html'
property 'svn:eol-style' set on 'language/it_IT/help/group_list.html'
property 'svn:eol-style' set on 'language/it_IT/help/cat_move.html'
property 'svn:eol-style' set on 'language/it_IT/help/advanced_feature.html'
property 'svn:eol-style' set on 'language/it_IT/help/notification_by_mail.html'
property 'svn:eol-style' set on 'language/it_IT/help/user_list.html'
property 'svn:eol-style' set on 'language/it_IT/help/synchronize.html'
property 'svn:eol-style' set on 'language/it_IT/help/cat_perm.html'
property 'svn:eol-style' set on 'language/it_IT/help/thumbnail.html'
property 'svn:eol-style' set on 'language/it_IT/help/cat_modify.html'
property 'svn:eol-style' set on 'language/it_IT/about.html'
property 'svn:eol-style' set on 'language/it_IT/help.html'
property 'svn:eol-style' set on 'admin/template/goto/history.tpl'
property 'svn:eol-style' set on 'template/yoga/calendar_navbar.tpl'

Code:

[pierrick@plegall] /tmp/20
$ svn st
 M     language/it_IT/help/cat_modify.html
 M     language/it_IT/help/advanced_feature.html
 M     language/it_IT/help/cat_options.html
 M     language/it_IT/help/maintenance.html
 M     language/it_IT/help/notification_by_mail.html
 M     language/it_IT/help/thumbnail.html
 M     language/it_IT/help/group_list.html
 M     language/it_IT/help/cat_perm.html
 M     language/it_IT/help/index.php
 M     language/it_IT/help/cat_move.html
 M     language/it_IT/help/site_manager.html
 M     language/it_IT/help/history.html
 M     language/it_IT/help/permalinks.html
 M     language/it_IT/help/search.html
 M     language/it_IT/help/configuration.html
 M     language/it_IT/help/user_list.html
 M     language/it_IT/help/synchronize.html
 M     language/it_IT/iso.txt
 M     language/it_IT/help.html
 M     language/it_IT/install.lang.php
 M     language/it_IT/about.html
 M     language/it_IT/index.php
 M     language/it_IT/admin.lang.php
 M     language/it_IT/common.lang.php
 M     tools/release_creation.readme
 M     plugins/add_index/admin/main_page.php
 M     plugins/c13y_upgrade/initialize.inc.php
 M     plugins/c13y_upgrade/main.inc.php
 M     include/php_compat/index.php
 M     include/ws_protocols/index.php
 M     include/functions_mail.inc.php
 M     include/class_smtp_mail.inc.php
 M     admin/element_set_ranks.php
 M     admin/template/goto/history.tpl
 M     install/upgrade_1.7.0.php
 M     install/db/79-database.php
 M     install/db/76-database.php
 M     install/db/33-database.php
 M     install/db/61-database.php
 M     install/db/37-database.php
 M     install/db/78-database.php
 M     template/yoga/calendar_navbar.tpl

See [Subversion] r3058

repie38 · 2009-03-04 16:32:22

this should be done for 2.0.x extension too, isn't it ?
i know, as we stock zip files on the extension manager, that it will be difficult to check

plg · 2009-03-04 20:55:54

repie38 wrote:
this should be done for 2.0.x extension too, isn't it ?

You're absolutely right repie38! Once we will have a more complete plugin documentation, this should be a best practice.

repie38 wrote:
i know, as we stock zip files on the extension manager, that it will be difficult to check

You're also right. Extensions are not checked before validation, they are visible as soon as they are submitted. The extension manager does not check the ZIP file content.

Piwigo.org

Announcement

#1 2009-01-06 22:35:27

[coding] Unix file format only

Code:

Code:

Code:

#2 2009-01-06 22:45:46

Re: [coding] Unix file format only

#3 2009-01-06 23:23:28

Re: [coding] Unix file format only

z0rglub wrote:

#4 2009-01-07 01:11:35

Re: [coding] Unix file format only

Code:

Code:

Code:

#5 2009-03-04 16:32:22

Re: [coding] Unix file format only

#6 2009-03-04 20:55:54

Re: [coding] Unix file format only

repie38 wrote:

repie38 wrote:

Board footer