Announcement

  •  » Engine
  •  » New architecture for themes

#46 2010-03-19 22:04:22

VDigital
Former Piwigo Team
Paris (FR)
2005-05-04
17680

Re: New architecture for themes

Why not this?

Code:

local
|
|-- css
|   |-- rules.css
|   |-- clear-rules.css
|   `-- dark-rules.css
|
|-- language
|   |
|   |-- fr_FR.php
|   |-- en_EN.php
|
|-- database.php
`-- config.php

KISS, not?


Piwigo.com: Start and run your own photo gallery. Signup and get 30 days to try for free, no commitment.
8-)

Offline

 

#47 2010-03-20 14:48:43

nicolas
Former Piwigo Team
2004-12-30
1232

Re: New architecture for themes

To avoid security issue or to easily protect database config file I think it will be better to put config.inc.php and database.inc.php in a config subdirectory of local.

I think we should keep double extension .inc.php to say that theses files are included.

Offline

 

#48 2010-03-20 17:22:16

VDigital
Former Piwigo Team
Paris (FR)
2005-05-04
17680

Re: New architecture for themes

Sounds strong and clear!


Piwigo.com: Start and run your own photo gallery. Signup and get 30 days to try for free, no commitment.
8-)

Offline

 

#49 2010-03-20 17:36:29

P@t
Piwigo Team
Nice
2007-06-13
4098

Re: New architecture for themes

Ok... I'll commit that... nicolas will do the database.inc.php move.

For language files, I prefer fr_FR.lang.php, en_UK.lang.php, etc...
It's easier to modify load_language function, and it's more logical to keep .lang.php extension.


P@t

Offline

 

#50 2010-03-21 20:16:34

rvelices
Former Piwigo Team
2005-12-29
1960

Re: New architecture for themes

I think its a lot cleaner now: all "user" files in one dir ...

Offline

 

#51 2010-03-21 20:44:49

P@t
Piwigo Team
Nice
2007-06-13
4098

Re: New architecture for themes

rvelices wrote:

I think its a lot cleaner now: all "user" files in one dir ...

What about prefilter for local css loading?
Do you have better solution?


P@t

Offline

 

#52 2010-03-21 21:28:49

rvelices
Former Piwigo Team
2005-12-29
1960

Re: New architecture for themes

P@t wrote:

What about prefilter for local css loading?
Do you have better solution?

No I don't have a better solution. I'm happy that it is done only during template compilation ...

Offline

 

#53 2010-03-22 17:21:07

rub
Former Piwigo Team
Lille
2005-08-26
5019

Re: New architecture for themes

First: Bad point! New local architecture is new theme architecture.
Don't open a new topic?

Great idea to put local on a unique and localizated place!

rvelices wrote:

P@t wrote:

What about prefilter for local css loading?
Do you have better solution?

No I don't have a better solution. I'm happy that it is done only during template compilation ...

It's dangerous for user witch add manually css file. Isn'it?
It's not possible to add a rule witch force compile template when a file is added or deleted on local directory?

Offline

 

#54 2010-03-22 22:03:57

P@t
Piwigo Team
Nice
2007-06-13
4098

Re: New architecture for themes

rub wrote:

rvelices wrote:

P@t wrote:

What about prefilter for local css loading?
Do you have better solution?

No I don't have a better solution. I'm happy that it is done only during template compilation ...

It's dangerous for user witch add manually css file. Isn'it?
It's not possible to add a rule witch force compile template when a file is added or deleted on local directory?

No... the aim of prefilter is to avoid file_exists function.
If we use file_exists function, we don't have to use prefilter at all (but we lose performances)
But I hope that everyone will use LocalFiles Editor ;-)


P@t

Offline

 

#55 2010-03-22 23:45:09

rub
Former Piwigo Team
Lille
2005-08-26
5019

Re: New architecture for themes

P@t wrote:

rub wrote:

rvelices wrote:


No I don't have a better solution. I'm happy that it is done only during template compilation ...

It's dangerous for user witch add manually css file. Isn'it?
It's not possible to add a rule witch force compile template when a file is added or deleted on local directory?

No... the aim of prefilter is to avoid file_exists function.
If we use file_exists function, we don't have to use prefilter at all (but we lose performances)

I didn't talk of file_exists function but more to a global function witch indicate a change (I don't have this function).

P@t wrote:

But I hope that everyone will use LocalFiles Editor ;-)

Not sure ;-) (A test on local gallery with ftp transfer of new file on production gallery for example)

Offline

 

#56 2010-03-23 00:14:16

tosca
Former Piwigo Team
Cévennes (France)
2006-09-23
567

Re: New architecture for themes

rub wrote:

P@t wrote:

But I hope that everyone will use LocalFiles Editor ;-)

Not sure ;-) (A test on local gallery with ftp transfer of new file on production gallery for example)

+1

Last edited by tosca (2010-03-23 00:15:21)


My galleries : Photos, Watercolours, Recipes

Offline

 

#57 2010-03-23 01:44:52

P@t
Piwigo Team
Nice
2007-06-13
4098

Re: New architecture for themes

rub wrote:

I didn't talk of file_exists function but more to a global function witch indicate a change (I don't have this function).

I don't have too... and I had looking for it for a while!


P@t

Offline

 

#58 2010-04-03 14:29:43

mathiasm
Former Piwigo Team
2006-02-06
2650

Re: New architecture for themes

With the new architecture, the [Bugtracker] ticket 243 seems meaningless, no ?

Offline

 

#59 2010-04-03 16:23:54

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13848

Re: New architecture for themes

mathiasm wrote:

With the new architecture, the [Bugtracker] ticket 243 seems meaningless, no ?

closed.

Offline

 
  •  » Engine
  •  » New architecture for themes

Board footer

Powered by FluxBB

github twitter newsletter Donate Piwigo.org © 2002-2024 · Contact