Announcement

  •  » Translations
  •  » [french, fr_FR] and [english, en_EN] new keys for 2.1

#1 2010-03-25 17:22:10

tosca
Former Piwigo Team
Cévennes (France)
2006-09-23
567

[french, fr_FR] and [english, en_EN] new keys for 2.1

I'm currently looking at both languages files in parallel, and find the following lines in the FR admin.lang.php file:

Code:

$lang['Guest Settings'] = 'Paramètres invité';
$lang['Main Page'] = 'Page Principale';
$lang['Photo Page'] = 'Page de la Photo';
$lang['Activate Navigation Bar'] = 'Activer la barre de navigation';
$lang['Activate Navigation Thumbnails'] = 'Activer les miniatures de navigation';
$lang['Activate icon "%s"'] = 'Activer l\'icone "%s"';
$lang['Activate field "%s"'] = 'Activer le champ "%s"';
$lang['Photo Properties'] = 'Propriétés de la photo';

with no correspondance in the EN file.

What shall I do with these lines? Remove them from the FR file, as I understand the EN file is the master one? Or are they missing, for whatever reason, in the EN file?


My galleries : Photos, Watercolours, Recipes

Offline

 

#2 2010-03-25 17:36:48

tosca
Former Piwigo Team
Cévennes (France)
2006-09-23
567

Re: [french, fr_FR] and [english, en_EN] new keys for 2.1

Sorry about the disruption: the missing lines are actually there ... but somewhere else in the file :(
I will put the FR lines at the same place as the EN ones, so nobody makes the same mistake another time.


My galleries : Photos, Watercolours, Recipes

Offline

 

#3 2010-03-25 18:42:32

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13791

Re: [french, fr_FR] and [english, en_EN] new keys for 2.1

tosca wrote:

Sorry about the disruption: the missing lines are actually there ... but somewhere else in the file :(
I will put the FR lines at the same place as the EN ones, so nobody makes the same mistake another time.

It is not a mistake, P@t has asked me about this point, I told him he could place the keys wherever he wants in the file, translation_analysis.php does not care about the position in the file.

Offline

 

#4 2010-03-25 18:46:47

tosca
Former Piwigo Team
Cévennes (France)
2006-09-23
567

Re: [french, fr_FR] and [english, en_EN] new keys for 2.1

plg wrote:

It is not a mistake, P@t has asked me about this point, I told him he could place the keys wherever he wants in the file, translation_analysis.php does not care about the position in the file.

The mistake was mine ;-)
I understand it causes no problem for the program; but for us, poor little minds, it is not so easy to find a few lines among several hundreds!


My galleries : Photos, Watercolours, Recipes

Offline

 

#5 2010-03-25 19:19:51

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13791

Re: [french, fr_FR] and [english, en_EN] new keys for 2.1

tosca wrote:

I understand it causes no problem for the program; but for us, poor little minds, it is not so easy to find a few lines among several hundreds!

I coded translation_analysis.php to avoid searching.

Offline

 

#6 2010-03-25 19:20:53

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13791

Re: [french, fr_FR] and [english, en_EN] new keys for 2.1

plg wrote:

I coded translation_analysis.php to avoid searching.

If you want any improvement in this script that may help translators. Just ask.

Offline

 

#7 2010-03-25 19:35:26

tosca
Former Piwigo Team
Cévennes (France)
2006-09-23
567

Re: [french, fr_FR] and [english, en_EN] new keys for 2.1

plg wrote:

I coded translation_analysis.php to avoid searching.

plg wrote:

If you want any improvement in this script that may help translators. Just ask.

Sorry, I didn't explain clearly enough.
As I'm currently reviewing the whole files (I didn't get the opportunity to do it before), I don't use the script and work with my usual editor; both EN and FR files are opened in adjacent windows so I can browse them at the same time.

... that's why I was surprised to find some lines were not at "the right" place ;-)

Last edited by tosca (2010-03-25 19:35:44)


My galleries : Photos, Watercolours, Recipes

Offline

 

#8 2010-03-25 21:54:34

tosca
Former Piwigo Team
Cévennes (France)
2006-09-23
567

Re: [french, fr_FR] and [english, en_EN] new keys for 2.1

In the photos_add_ftp.html file, I read this:

Code:

Each directory under "galleries" produces a category. There is no limit on deepness.

I think this might create some misunderstanding, as pwg_high and thumbnail subdirectories are actually under "galleries" but they don't produce categories.

You might want to write that somewhat differently.


My galleries : Photos, Watercolours, Recipes

Offline

 

#9 2010-03-25 22:03:36

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13791

Re: [french, fr_FR] and [english, en_EN] new keys for 2.1

tosca wrote:

I think this might create some misunderstanding, as pwg_high and thumbnail subdirectories are actually under "galleries" but they don't produce categories.

I wanted to write something true (and this is true 99.93% of the time) and simple. I didn't want to write "exceptions" in this very place, because pwg_high, pwg_representative, thumbnail ARE exceptions.

Do you have another suggestion?

Offline

 

#10 2010-03-25 22:21:55

tosca
Former Piwigo Team
Cévennes (France)
2006-09-23
567

Re: [french, fr_FR] and [english, en_EN] new keys for 2.1

plg wrote:

Do you have another suggestion?

Not right now, but I'll think about it and let you know if I find some simple alternative.


My galleries : Photos, Watercolours, Recipes

Offline

 

#11 2010-03-25 22:26:59

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13791

Re: [french, fr_FR] and [english, en_EN] new keys for 2.1

tosca wrote:

plg wrote:

Do you have another suggestion?

Not right now, but I'll think about it and let you know if I find some simple alternative.

That's fine :-)

Offline

 

#12 2010-03-25 22:59:47

tosca
Former Piwigo Team
Cévennes (France)
2006-09-23
567

Re: [french, fr_FR] and [english, en_EN] new keys for 2.1

plg wrote:

tosca wrote:

Not right now, but I'll think about it and let you know if I find some simple alternative.

That's fine :-)

Found something when doing the dishes ;-)

What do you think about:

Except for those named "thumbnail", "pwg-high" or "pwg_representative" (see explanations below), each directory under "galleries" produces a category. etc

And by the way, your 99,93% ...

plg wrote:

I wanted to write something true (and this is true 99.93% of the time)

... might not be so accurate, as every directory containing pictures has its thumbnail counterpart and might have a pwg_high too; so to reach such an amazing ratio, you'll need to nest a zillion directories without any picture in them :P


My galleries : Photos, Watercolours, Recipes

Offline

 

#13 2010-03-25 23:28:06

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13791

Re: [french, fr_FR] and [english, en_EN] new keys for 2.1

tosca wrote:

What do you think about:

Except for those named "thumbnail", "pwg-high" or "pwg_representative" (see explanations below), each directory under "galleries" produces a category. etc

That's very good.

tosca wrote:

And by the way, your 99,93% ...

plg wrote:

I wanted to write something true (and this is true 99.93% of the time)

... might not be so accurate, as every directory containing pictures has its thumbnail counterpart and might have a pwg_high too; so to reach such an amazing ratio, you'll need to nest a zillion directories without any picture in them :P

Well, I was meaning the millions of possibilities to call a directory with another name than thumbnail, pwg_high, pwg_representative :-)

Offline

 

#14 2010-03-26 00:01:19

tosca
Former Piwigo Team
Cévennes (France)
2006-09-23
567

Re: [french, fr_FR] and [english, en_EN] new keys for 2.1

Did you modify something in the EN admin.lang.php? I got this message when I tried to commit:

Code:

Error: Error while performing action: Échec de la propagation (commit), détails :
Fichier ou répertoire 'en_UK/admin.lang.php' obsolète ; mettre à jour
resource out of date; try updating

plg wrote:

Except for those named "thumbnail", "pwg-high" or "pwg_representative" (see explanations below), each directory under "galleries" produces a category. etc

That's very good.

Will do the modification then.


My galleries : Photos, Watercolours, Recipes

Offline

 

#15 2010-03-26 00:02:45

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13791

Re: [french, fr_FR] and [english, en_EN] new keys for 2.1

tosca wrote:

Did you modify something in the EN admin.lang.php? I got this message when I tried to commit:

Yes, probably. Just do what SVN ask : update (you won't loose your local modification, don't be afraid)

Offline

 
  •  » Translations
  •  » [french, fr_FR] and [english, en_EN] new keys for 2.1

Board footer

Powered by FluxBB

github twitter newsletter Donate Piwigo.org © 2002-2024 · Contact