Announcement

  •  » Beta testing
  •  » [Stripped + Embedded Videos] incompatibility

#1 2012-08-31 12:13:05

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13791

[Stripped + Embedded Videos] incompatibility

Hi Zaphod,

Theme Stripped seems to be incompatible with [extension by mistic100] Embedded Videos

On picture.php, there is a hidden div .hideTabsZone that prevents us from clicking on the "play" button :-/

(I have tested with a Vimeo video)

Offline

 

#2 2012-08-31 12:32:48

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13791

Re: [Stripped + Embedded Videos] incompatibility

additional info: the problem occurs only with styles Black/White, not with Original (of course...)

Offline

 

#3 2012-08-31 12:42:39

Zaphod
Former Piwigo Team
2006-11-13
441

Re: [Stripped + Embedded Videos] incompatibility

The purpose of hideTabsZone is to close the tabs when you click outside the tabs.
Do you have a link to make a test? (I do not use video so I've never tested any video plugin).

Offline

 

#4 2012-08-31 12:54:00

mistic100
Former Piwigo Team
Lyon (FR)
2008-09-27
3277

Re: [Stripped + Embedded Videos] incompatibility

Zaphod wrote:

The purpose of hideTabsZone is to close the tabs when you click outside the tabs.

that's a good idea but I think it's very bad to add an overlay to the whole page, at least it should be UNDER #theImage


example http://www.strangeplanet.fr/piwigo/pict … e=stripped

Offline

 

#5 2012-08-31 13:14:11

Zaphod
Former Piwigo Team
2006-11-13
441

Re: [Stripped + Embedded Videos] incompatibility

I tried to do it under the image... but it didn't work.
Anyway, with the current system, when it's an image, the right click on the image works (I wouldn't have chosen a system where you lose the right click)...
So it doesn't overlay the whole thing.

I don't remember the details of what has been done... I'll have to check.

Offline

 

#6 2012-08-31 13:19:43

mistic100
Former Piwigo Team
Lyon (FR)
2008-09-27
3277

Re: [Stripped + Embedded Videos] incompatibility

might be a difference between an image and an iframe but I'm sure that with Embedded Video, the layer overlap the whole thing

Offline

 

#7 2012-08-31 13:48:42

Zaphod
Former Piwigo Team
2006-11-13
441

Re: [Stripped + Embedded Videos] incompatibility

I never tested it with a video... And I don't know how embedded video works.
Most times, Content plugins don't work correctly with stripped as the image structure is different (i need more classes to do all I want).

In the end I think there will be 2 solutions :
- a workaround that deactivate the hidetabszone with this particular plugin (easy but not satisfying... Ayway I've got dozens tweaks like this already in stripped).
- a modification of the plugin to adapt to stripped (not satisfying either...)

Offline

 

#8 2012-08-31 13:52:32

mistic100
Former Piwigo Team
Lyon (FR)
2008-09-27
3277

Re: [Stripped + Embedded Videos] incompatibility

with Emebedded Videos you just give the link of the video on the plugin admin page, and that's all :D


yes I though removing your layer with a css rule, it's the easiest way

Offline

 
  •  » Beta testing
  •  » [Stripped + Embedded Videos] incompatibility

Board footer

Powered by FluxBB

github twitter newsletter Donate Piwigo.org © 2002-2024 · Contact