Announcement

#31 2014-10-12 09:22:44

Serge D
Member
US
2014-07-15
372

Re: [Plugin] Fotorama

Latest version : when in full mode and clicking refresh on the page I am getting "undefined index in main.inc.php line 156"
I did save settings just in case, but still getting the error.
In my setup both Nav style and and full screen nav style are false so I suspect if ($conf['Fotorama']['nav'] == 'thumbs' or $conf['Fotorama']['fullscreen_nav'] == 'thumbs') cannot find the value as it is not stored

Last edited by Serge D (2014-10-12 09:24:14)

Offline

 

#32 2014-10-12 10:04:21

Serge D
Member
US
2014-07-15
372

Re: [Plugin] Fotorama

Love it!

Suggestion:
new mode for caption to allow display as a bar on the bottom with "album title | Image title" on the left and "N/N" on the right
Then to go fancy max/min button would act as trigger to show/hide the bar. Right now it is really just closes the view...

Offline

 

#33 2014-10-12 16:45:51

rvelices
Piwigo Team
2005-12-29
1960

Re: [Plugin] Fotorama

Bug Fotorama: function Fotorama_element_content should return the first passed parameter as argument. This is because render_element_content is a change trigger. Because of that any other plugin that uses this change trigger is ignored.
Aka: rv gmaps, video js, modus ...

Offline

 

#34 2014-10-13 13:36:04

JanisV
Member
2013-09-25
85

Re: [Plugin] Fotorama

Serge D wrote:

Latest version : when in full mode and clicking refresh on the page I am getting "undefined index in main.inc.php line 156"
I did save settings just in case, but still getting the error.
In my setup both Nav style and and full screen nav style are false so I suspect if ($conf['Fotorama']['nav'] == 'thumbs' or $conf['Fotorama']['fullscreen_nav'] == 'thumbs') cannot find the value as it is not stored

How this values can be cleared? That is your play with config or it should be fixed in Fotorama?

Offline

 

#35 2014-10-13 13:40:02

JanisV
Member
2013-09-25
85

Re: [Plugin] Fotorama

mmoy wrote:

I'm still getting a minor annoyance: when I activate "replace picture page", and then click the info button, I do get to the picture page, but some buttons bring me back to the Fotorama while they shouldn't:

- The "add to favorites" does its job, but goes back to the Fotorama immediately, I'd rather stay on the picture page.

- The "show metadata" from [extension by maple] EXIF View loads the page picture.php?/N/category/M&metadata, but then the "metadata" argument is ignored, and I get to the Fotorama view. This makes [extension by maple] EXIF View unusable.

For both cases, a very, very dirty fix would be to apply this to the core to preserve the slidestop GET parameter:

--- include/functions_url.inc.php    (revision 29905)
+++ include/functions_url.inc.php    (working copy)
@@ -254,6 +254,9 @@
   }
   $url .= make_section_in_url($params);
   $url = add_well_known_params_in_url($url, $params);
+  if (isset($_GET['slidestop'])) {
+    $url .= '&slidestop=';
+  }
   return $url;
}

I can't find a clean way, but I'm pretty sure someone will be able to point out a way to preserve a GET parameters in duplicate_picture_url().

Yes, known problem and I havn't a clean way too. May be devels can help us?

Last edited by JanisV (2014-10-13 13:42:40)

Offline

 

#36 2014-10-22 18:42:34

Tom77
Guest

Re: [Plugin] Fotorama

Notice: Undefined index: nav in WWW/...../plugins/Fotorama/main.inc.php on line 200

This ist what I see for a second by click on the Picture zu enlarge AND when I Close Fotorama.

 

#37 2014-10-22 19:02:09

rvelices
Piwigo Team
2005-12-29
1960

Re: [Plugin] Fotorama

Tom77 wrote:

Notice: Undefined index: nav in WWW/...../plugins/Fotorama/main.inc.php on line 200

This ist what I see for a second by click on the Picture zu enlarge AND when I Close Fotorama.

If you save once the options in fotorama admin screen, do you still get the warning ?

Offline

 

#38 2014-10-22 20:05:43

Tom77
Guest

Re: [Plugin] Fotorama

No!

Please click on one of the photos on

http://werkovits.at/photoart/index.php?/category/36

You will see this message for one second. Same when you leave "the big Picture view".

 

#39 2014-10-23 13:02:14

mervyngroves
Member
2014-07-14
11

Re: [Plugin] Fotorama

I have the same issue, undefined index nav in /plugins/Fotorama/main.inc.php line 200.

I'm using Greydragon theme.

Offline

 

#40 2014-10-24 14:19:58

Martin Sillence
Guest

Re: [Plugin] Fotorama

RE: undefined index nav in /plugins/Fotorama/main.inc.php line 200.

I hit this and it seemed to disappear when I reset the settings for this plugin

 

#41 2014-11-05 10:57:14

JanisV
Member
2013-09-25
85

Re: [Plugin] Fotorama

Tom77 wrote:

Notice: Undefined index: nav in WWW/...../plugins/Fotorama/main.inc.php on line 200

This ist what I see for a second by click on the Picture zu enlarge AND when I Close Fotorama.

Hi Tom77!

Notice message fixed in 2.7.r. For apply fix you should update your Fotorama settings (simply click Save button on Fotorama settings page).

Offline

 

#42 2014-11-05 12:01:08

photo_friend
Member
Berlin
1970-01-01
201

Re: [Plugin] Fotorama

Hi,

To get the Fotorama photo always in the highest resolution, I have to change to lines of code. But with each update of the plugin, I have to change it again. Is it possible to implement a variable in the Fotorama backend to choose the size of the displayed photo? I use 4K (Ultra HD) screens and a high resolution is important for me.

Thanks again



$row['derivative'] = DerivativeImage::get_one('xxlarge', $row['src_image']);
$row['derivative_big'] = DerivativeImage::get_one('xxlarge', $row['src_image']);

Last edited by photo_friend (2014-12-27 10:58:16)

Offline

 

#43 2014-11-05 21:47:40

Tom77
Guest

Re: [Plugin] Fotorama

Thank you! Works great!

 

#44 2014-11-09 11:18:35

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13541

Re: [Plugin] Fotorama

mmoy wrote:

I'm still getting a minor annoyance: when I activate "replace picture page", and then click the info button, I do get to the picture page, but some buttons bring me back to the Fotorama while they shouldn't:

- The "add to favorites" does its job, but goes back to the Fotorama immediately, I'd rather stay on the picture page.

For this specific problem, I think we should convert this link into an AJAX action.

mmoy wrote:

- The "show metadata" from [extension by maple] EXIF View loads the page picture.php?/N/category/M&metadata, but then the "metadata" argument is ignored, and I get to the Fotorama view. This makes [extension by maple] EXIF View unusable.

The "show metadata" button is not related to [extension by maple] EXIF View, it's a core feature. Exif View only makes the EXIF key/value more readable.

One more time, I wonder if the current ergonomy is the right one about showing/hiding metadata. Maybe it would be better to have a block with metadata and a javascript action to show/hide, with no page reload.

Anyway, for now, I will see if we can cleanly modify Piwigo core to avoid losing the "slideshow" GET parameter.

Offline

 

#45 2014-11-09 12:56:58

sport
Member
2014-03-16
93

Re: [Plugin] Fotorama

plg wrote:

One more time, I wonder if the current ergonomy is the right one about showing/hiding metadata. Maybe it would be better to have a block with metadata and a javascript action to show/hide, with no page reload..

i like this idea..

Offline

 

Board footer

Powered by FluxBB

github twitter newsletter Donate Piwigo.org © 2002-2022 · Contact