#16 2015-03-24 21:29:31

gmccord
Member
2015-03-24
4

Re: [Plugin] Share This v.1.0.4

FYI, I use the videojs plugin, and when I enable sharethis 1.01, my video display pages lose all of their formatting. I have to disable sharethis to make videojs work properly.

When I firebug-ged the page, there was nothing in the <head> tag and none of the stuff I would normally expect to see prior to the <body>

Thought you should know. This did not happen with v1.00

Thanks!

Gray

Offline

 

#17 2015-03-24 23:50:12

Serge D
Member
US
2014-07-15
384

Re: [Plugin] Share This v.1.0.4

gmccord wrote:

FYI, I use the videojs plugin, and when I enable sharethis 1.01, my video display pages lose all of their formatting. I have to disable sharethis to make videojs work properly.

Fixed in 1.0.2 - image derivative information is empty/missing. Post to Facebook would be made without image reference
Will post tonight

Offline

 

#18 2015-03-26 00:56:43

Serge D
Member
US
2014-07-15
384

Re: [Plugin] Share This v.1.0.4

version 1.0.2
+ Corrected PayPal link for "Donate" link in admin area
- Fixed issue with VideoJS plugin when image derivative information is empty/missing. Post to Facebook would be made without image reference

Offline

 

#19 2015-04-29 21:17:56

Serge D
Member
US
2014-07-15
384

Re: [Plugin] Share This v.1.0.4

version 1.0.3
+ ALL: Added better reference for OG: metadata
+ ALL: Photo description extended to include Gallery title and author (if provided)
+ Pinterest: Added Description. Fixed image reference. Improved Pinterest widget integration
+ Tumblr: New option. Experimental

Offline

 

#20 2015-04-30 07:45:50

ddtddt
Piwigo Team
Quetigny - France
2007-07-27
7257

Re: [Plugin] Share This v.1.0.4

Hi,

Can you add en_UK description on language folder for Can I add translation


You love Piwigo so don't hesitate to participate, learn more on the "Contribute to Piwigo" page. If you don't have much time for contribution, you can also help the project with a donation.

Offline

 

#21 2015-04-30 17:46:49

Serge D
Member
US
2014-07-15
384

Re: [Plugin] Share This v.1.0.4

Can do
since it is first time I would be doing so, any suggestions on best practices of creating/maintaining language folders?
if it is in the docs somewhere, please share the link
For example: I have created the folder as you requested with description.txt and empty plugin.lang.php. Now what?

Offline

 

#22 2015-04-30 18:52:40

mistic100
Former Piwigo Team
Lyon (FR)
2008-09-27
3277

Re: [Plugin] Share This v.1.0.4

There is not doc for that :(

You might look at how other plugins work (or https://github.com/mistic100/Piwigo-Skeleton)

plugin.lang.php file contains all strings you use in l10n (PHP) and translate (Smarty)
I recommend you do not use cryptic keys like "button_label" but the english term, this way partial languages naturally fall back to Engligh

description.txt just contain the plugin description you put in main.inc.php

Offline

 

#23 2015-04-30 19:14:43

mistic100
Former Piwigo Team
Lyon (FR)
2008-09-27
3277

Re: [Plugin] Share This v.1.0.4

well I already did it for GreyDragon isn't it ?

Offline

 

#24 2015-04-30 23:02:18

Serge D
Member
US
2014-07-15
384

Re: [Plugin] Share This v.1.0.4

mistic100 wrote:

well I already did it for GreyDragon isn't it ?

not sure what you mean beside that I just used Elegant's language folder
this does not really translates it.

Offline

 

#25 2015-04-30 23:07:49

Serge D
Member
US
2014-07-15
384

Re: [Plugin] Share This v.1.0.4

mistic100 wrote:

There is not doc for that :(

You might look at how other plugins work (or https://github.com/mistic100/Piwigo-Skeleton)

plugin.lang.php file contains all strings you use in l10n (PHP) and translate (Smarty)
I recommend you do not use cryptic keys like "button_label" but the english term, this way partial languages naturally fall back to Engligh

description.txt just contain the plugin description you put in main.inc.php

this is starting point, but considering sheer size of parsing and aggregating all the values, I was looking for a way to "scrap" theme or plugin files in some programmatic way
Coming back to WP example, there are things like https://wpml.org/ which allow you do that from within the system.
Considering that translation is done by PWG code, it would be great if there was a hook/UI allowing to do that

Offline

 

#26 2015-05-01 00:42:43

mistic100
Former Piwigo Team
Lyon (FR)
2008-09-27
3277

Re: [Plugin] Share This v.1.0.4

[extension by mistic100] Language Analysis
it does not generate files but it lists which translations are needed

Offline

 

#27 2015-05-01 01:01:48

Serge D
Member
US
2014-07-15
384

Re: [Plugin] Share This v.1.0.4

mistic100 wrote:

[extension by mistic100] Language Analysis
it does not generate files but it lists which translations are needed

That's cool!
Few things to report:
* drop down does not work in IE - I cannot click any items, have to use KB only
* works with Plugins but not themes
* Warning: file_put_contents(_data/plugin_lang_analysis/GDThumb.php): failed to open stream: Permission denied in .../plugins/plugin_lang_analysis/admin.php on line 72

Offline

 

#28 2015-05-01 01:06:42

mistic100
Former Piwigo Team
Lyon (FR)
2008-09-27
3277

Re: [Plugin] Share This v.1.0.4

* I don't care about IE
* hence the name of the menu item :-)
* well that's your config, "permission denied", clear enough

Offline

 

#29 2015-05-01 01:34:27

Serge D
Member
US
2014-07-15
384

Re: [Plugin] Share This v.1.0.4

mistic100 wrote:

* I don't care about IE

Still widely used browser, and just shows that proprietary code is used somewhere or there is something in templates cached and causing error. Drop down with search is very simple component. BTW, it is IE11, so it is working fine with all normal JS/CSS
BTW, it seems to be "first time use" issue as error no longer appear, hence coding as I did not change anything on my end

mistic100 wrote:

* hence the name of the menu item :-)

But it is great tool, Sir! Please forgive my ignorance, but could it be easy to provide coverage for themes too, could it not?

mistic100 wrote:

* well that's your config, "permission denied", clear enough

It just happened to be my plugin as I did pick it first
Error is at
.../admin.php?page=plugin-plugin_lang_analysis&plugin_id=GDThumb&analyze

But when you do create _data/plugin_lang_analysis folder, you do not set any permissions, causing it not to be accessible from your code
After further review of admin.php

@mkdir(PLA_DATA, true, 0755);

This is wrong syntax, per http://php.net/manual/en/function.mkdir.php, it should be @mkdir(PLA_DATA, 0755, true);

Soo, your cooking, Sir :)

Last edited by Serge D (2015-05-01 01:46:29)

Offline

 

#30 2015-05-04 15:52:04

jodgrulz
Guest

Re: [Plugin] Share This v.1.0.4

Hello all,
New to Piwigo. Seems to be pretty cool!
So I got started on my hosting site no problem. Then I installed and enabled "Share This" plug in and started getting this:

Notice: Undefined index: tumblr in /hermes/walnaweb02a/b1592/hy.jbauctionhouse/album/plugins/ShareThis/main.inc.php on line 49 Warning: Cannot modify header information - headers already sent by (output started at /hermes/walnaweb02a/b1592/hy.jbauctionhouse/album/plugins/ShareThis/main.inc.php:49) in /hermes/walnaweb02a/b1592/hy.jbauctionhouse/album/include/page_header.php on line 101

It stayed at the top of the page in admin and in my gallery. I noticed something funny right away when I installed it, I didnt see it with the rest of my plugins, however I did see it listed on the left hand column. So I had to deactivate it and then all was back to normal.

Any ideas what Im doing wrong or what the problem is?

Thanks,
Jeff

 

Board footer

Powered by FluxBB

github twitter newsletter Donate Piwigo.org © 2002-2024 · Contact