•  » Engine
  •  » Make your extensions compatible with Piwigo 11

#1 2020-12-21 11:31:12

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13850

Make your extensions compatible with Piwigo 11

Dear extensions developers,

Piwigo 11 (the one after version 2.10) is about to be released! As usual, releasing a new version with no extension compatible makes no sense. Nobody will update and that would be even worse for a first time installation. Piwigo 11 needs as many compatible plugins and themes as possible.

Piwigo 11 brings many changes in the administration pages. For example, if your plugin adds an action link on the "edit this photo" page, you'll have to update your plugin. The HTML was indeed changed quite a lot on this page.

We have described some technical changes that might affect plugins on Technical changes in Piwigo 11

So what's next?

1) install [Forum, topic 30733] Piwigo 11beta5 or better, run Piwigo from Git (branch master for now)

2) test your extension on it

3a) if you have changes on your code (like new translations, click on "detect languages"), publish a new revision of your extension, compatible 11

3b) if you have no change and don't feel the need to have a new revision, mark your latest revision as compatible with version 11

If you need any help we're here to help!

Offline

 

#2 2020-12-21 21:50:29

TheDoc
Member
Munich / Germany
2015-10-18
173

Re: Make your extensions compatible with Piwigo 11

Thanks for the heads-up! Unfortunately, I don't have any means to install a second PiWiGo instance for testing. So I'll have to do testing on prod once the new version is out...

Offline

 

#3 2020-12-21 22:03:22

windracer
Member
St. Pete, FL
2014-12-28
493

Re: Make your extensions compatible with Piwigo 11

My plugin seems to work as-is (even though it adds a tab to the Edit Photos page) but I'll do a little more testing before marking it compatible.

Should I add the "Has Settings:" line to main.inc.php for future compatibility even though my plugin has no additional settings (no call to get_admin_plugin_menu_links)? If I put in "Has Settings: false" will that cause any problems with older versions of Piwigo, or will it just be ignored? I might update my documentation screenshots as well, but that seems to be about it.

Offline

 

#4 2020-12-22 18:34:39

romanf
Member
2017-01-22
40

Re: Make your extensions compatible with Piwigo 11

MenuRandomPhoto works. But how do I mark it as compatible? I have a login for the forum but on the extensions page, I can't seem to login... :-\

I must be missing something very trivial...?

Any help apreciated
Roman

Offline

 

#5 2020-12-22 20:03:10

windracer
Member
St. Pete, FL
2014-12-28
493

Re: Make your extensions compatible with Piwigo 11

On the Extensions tab of this site, click on "My Extensions" on the lower left-hand side. You should then be able to modify your latest revision to add the new version (11) tag.

https://www.windracer.net/photos/_data/i/galleries/misc/ppm-version-tag-me.png

Last edited by windracer (2020-12-22 20:29:43)

Offline

 

#6 2020-12-22 20:37:29

romanf
Member
2017-01-22
40

Re: Make your extensions compatible with Piwigo 11

Argh! I can login into the forum, but NOT into the Extensions part. There is also no "reset password" over there...

Please help anybody? :(

-Roman

Offline

 

#7 2020-12-23 09:00:26

nicolas
Former Piwigo Team
2004-12-30
1232

Re: Make your extensions compatible with Piwigo 11

romanf wrote:

Argh! I can login into the forum, but NOT into the Extensions part. There is also no "reset password" over there...

Please help anybody? :(

-Roman

I encountered the problem yesterday and @plg help by copying the hashed password to the right database table.

Offline

 

#8 2020-12-23 12:34:21

romanf
Member
2017-01-22
40

Re: Make your extensions compatible with Piwigo 11

@plg kann you please help? I can login to the Forum but not to the Extensions part...

Thanks
Roman

Offline

 

#9 2020-12-30 10:27:42

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13850

Re: Make your extensions compatible with Piwigo 11

@romanf I copied your password from the forum to the extension manager. Can you login now?

Offline

 

#10 2020-12-30 10:54:38

romanf
Member
2017-01-22
40

Re: Make your extensions compatible with Piwigo 11

Yup, works! :)

Thanks a lot!
-Roman

Offline

 

#11 2020-12-30 12:01:02

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13850

Re: Make your extensions compatible with Piwigo 11

I've checked the compatibility with about 20 of my plugins. The only "problem" I have encountered is with trigger "get_admin_plugin_menu_links". This trigger is used to add the plugin settings link to the menu. As you have understood, the plugin is no longer in the menu with Piwigo 11. The trigger is used at another time and you can no longer rely on its execution on every admin page.

For example, in plugin Community I used this trigger to initialize the number of pending photos. I had to use another trigger, see [Github] Piwigo-community commit 8d7f9c81

Offline

 

#12 2020-12-30 13:58:05

erAck
Only trying to help
2015-09-06
2147

Re: Make your extensions compatible with Piwigo 11

Doing a short grep over my installation revealed that over 2/3 (24) of installed plugins (34) use get_admin_plugin_menu_links, I wonder who all will take care of these extensions.


Running Piwigo at https://erack.net/gallery/

Offline

 

#13 2020-12-30 14:51:13

romanf
Member
2017-01-22
40

Re: Make your extensions compatible with Piwigo 11

Maybe I don't understand the note at the end of the page https://piwigo.org/doc/doku.php?id=dev:changes_in_2.11 not corectly: "This will obviously be only compatible with Piwigo 11+. So maybe you can keep both for a while. "

I read this as "add the 'has headers: true' to the head of main.inc.php but keep the hook for now...

Or how was this meant?

-Roman

Offline

 

#14 2020-12-30 15:07:46

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13850

Re: Make your extensions compatible with Piwigo 11

OK, don't panic, the get_admin_plugin_menu_links still has an effect, but instead of being triggered for all admin pages, it is triggered only on the plugins page.

When we wrote keep both "Has Settings" header + get_admin_plugin_menu_links for a while, it's because if you remote get_admin_plugin_menu_links, your plugin is immediately no longer compatible with Piwigo 2.10. Only Piwigo 11 understands "Has Settings".

I made the change on Community, because I absolutely don't plan to release new version of this plugin for older Piwigo versions. But if I have to publish one, I will have to provide get_admin_plugin_menu_links again.

Offline

 

#15 2020-12-31 13:47:52

homdax
Member
Sweden
2015-02-02
312

Re: Make your extensions compatible with Piwigo 11

Allow me to throw in a reminder about the Community Plugin, hoping that 2.11 don't mess it up somehow.

Offline

 
  •  » Engine
  •  » Make your extensions compatible with Piwigo 11

Board footer

Powered by FluxBB

github twitter newsletter Donate Piwigo.org © 2002-2024 · Contact