Announcement

  •  » Requests
  •  » Improved HTML and layout

#16 2005-07-31 01:36:36

yoDan
Member
France
2005-06-05
39

Re: Improved HTML and layout

I want to give you an update about the process of creating a W3C-friendly template for PWG.

Short version: it is going to take more time than I thought!

You may browse at http://yo.dan.free.fr/PWG/category.php my first gallery, featuring the new template. Here is a short list of problems right now:
- not all pages have been converted to the new template (especially admin pages), and not all configurations have been tested (normal user logged in, admin logged in, user not logged in, possibly allowed to add/edit/delete a comment, and so on)
- a few PHP functions that generate (X)HTML code have to be (slightly) modified
- class names are not entirely consistent, sometimes reusing old names, sometimes creating new ones...

In the end, it needs more work, but it is making progress.
(Dude, that sounds like my weekly report to my boss! :))

-- Daniel

Offline

 

#17 2005-08-10 22:45:58

chrisaga
Former Piwigo Team
France (92)
2005-08-10
543

Re: Improved HTML and layout

Hi yoDan

First of all, I like your work on PWG templates very much.

I had a conversation with Zorglub about templates i did for the 1.3 branch (never publiquely released :-(
and he told me about your work. The goal is the same and i thought about building 1.4 version of my templates and themes.
If you'd like I could rather give you a hand on packaging your clear2 template. It'll be a very good base to buil my own templates.

Just make your work available for me "as is" and tell me what you are not working on now.
I understand reading this thead that you made some changes on the PHP code too. If you have not packaged a MOD yet, jut give the files, i'll do a diff and will make the MOD.

Regards

Christophe


cepatre.net
Utilisateur depuis la version 1.3, Impliqué depuis la 1.4, Responsable du template des 1.5 et 1.6  ... et en (in)disponibilité sur la 1.7. J'ai fait l'impasse, et j'ai sauté directement en 2.2.2 !

Offline

 

#18 2005-08-12 17:21:38

droopy191
Member
BZH, France
2005-08-12
8

Re: Improved HTML and layout

hello YoDan,

I see your template: one only word, beautiful.
I am also reworking PWG to make it XHTML Valid (Yes,  I read your post about HTML vs XHTML ;-) )

I found a few bugs in the php core that prevent to be be XHTML or HTML valid
I hope that my post can help you: http://forum.phpwebgallery.net/viewtopic.php?id=4326

Laurent

Offline

 

#19 2005-08-14 00:19:32

yoDan
Member
France
2005-06-05
39

Re: Improved HTML and layout

This work generated a few private emails, until zorglub (himself!) asked us to go public. So I am just pasting here one of my series of interrogations. It is late, so I am going to leave it in French. ;-)

Deja, pour les tetes brulees, j'ai mis mon travail ici : http://yo.dan.free.fr/tmp/clear2.tgz

L'archive contient un fichier de PWG modifie (functions_html.inc.php) et le repertoire du template, lui-meme etant le repertoire clear avec quelques fichiers modifies.

Les pages picture et category devraient etre bonnes (c'etait le but) et completes, je pense. Je n'ai pas pu tester toutes les configurations (comme je l'ai ecrit sur le forum), mais je ne pense pas avoir oublie de "champ".

En revanche, j'ai vu que les modifications (par exemple : changer les noms de classes dans les menus) avaient "casse" les pages admin. C'est la que le courage m'a manque. :) D'autant que je decouvre PWG et que je decouvre qu'il est tres touffu, avec beaucoup d'ecrans : j'imagine que le tpl est long et qu'il y a en plus pas mal de code (X)HTML eparpille dans le code PHP (le {ADMIN_CONTENT}{ADMIN_CONTENT_2} me fait peur).

Mon probleme principal : est-ce que l'on peut faire ce template sans casser la compatibilite avec le code precedent, ou faut-il modifier le code de PWG et forcer une version 1.5 ? De plus, faire sa mise en page en CSS presente des avantages mais demande des connaissances (du CSS tel que defini par le W3C d'abord, et ensuite du CSS tel qu'il est supporte par les navigateurs reels). Ceux qui ont ecrit des templates pour les versions 1.x (x < 5) ne vont peut-etre pas tous reussir a porter leurs templates pour l' (hypothetique) version 1.5. Les bons vieux tableaux et toutes les dimensions en pixels, comme en 1995, c'est moins accessibles (cote visiteur), mais c'est plus facile (cote auteur) ! ;-)

Il faudrait plus de recul, sur le contenu des pages (j'ai souvent eu l'impression qu'il y avait plein d'informations a mettre, alors tout etait empile au centre de la page), sur les templates deja existants (pour voir ceux qui pourraient casser), et sur l'historique de PWG (comment se sont passees les precedentes cassures, quelle evolution est envisagee).

J'attends vos reactions avant de modifier d'autres fichiers tpl. En tout cas, je suis toujours motive pour remanier les pages.
A+

Offline

 

#20 2005-08-14 01:21:15

chrisaga
Former Piwigo Team
France (92)
2005-08-10
543

Re: Improved HTML and layout

So to public forum we go ...

First I think yoDan's work is very good. I started to work on it's files and found they are a good base to build the flexible light template I wanted.

Second I think people really are interested in themes (colors backgrounds, sometimes layout) not in templates. So if we achieve to make a highly customizable, standards compliant template which works with the most common browsers, even the buggy brain damaged (put here the name of the widely used browser you hates because you spend nights on getting your standard compliant CSS work with it), *and we write the manual* other people need to set colors, backgrouds, ... they like, it would be very good for PWG 1.4 and hopefully 1.5 and above.

Third I think that the official templates (default, wood, ...) will be quite easy to port;

I'll let you know how it goes.
It'll be fun to be able to release a test template soon.

Chris


cepatre.net
Utilisateur depuis la version 1.3, Impliqué depuis la 1.4, Responsable du template des 1.5 et 1.6  ... et en (in)disponibilité sur la 1.7. J'ai fait l'impasse, et j'ai sauté directement en 2.2.2 !

Offline

 

#21 2005-08-14 16:24:33

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13789

Re: Improved HTML and layout

I'm sure Yodan will translate his post to english, I continue this thread in english.

Yodan, I had discussed the following point with Gweltas some times ago : does the administrative section and public section share the same CSS stylesheet? (is it important for designers to modify administration display?). My opinion was clearly to separate : it is totally useless to change administration display. Other very designed famous application (Dotclear for instance) share my opinion. Gweltas did not agree and wanted only one stylesheet. As template responsible, we did as he wanted.

Today, Yodan shows that the most important is public section regarding to presentation. Considering the total silence of Gweltas since 3 months and knowing that he's still alive (activity from him on his website), I take the decision to say OK for breaking presentation between public and admin sections : 2 distinct stylesheets. Anyway, this can be done in template "clear" without doing it in template "default".

HTML code can only be found in template files template/*/**.tpl and in include/functions_html.inc.php for too complex HTML code (requiring recursivity for instance). Nowhere else.

If a template requires modifications in any file outside template directory, then a MOD must be associated to the template. If the modifications can be integrated into the official release, I'll do it.

Creating a template strongly based on CSS (instead of HTML tables) is the right way to go. No worry about templates compatible with previous releases : a standard compliant template worth it. Previous branchs (1.3, 1.4) have created major incompatibilities (1.3 = template system introduction, 1.4 = new template system) and no user send me any threatening letter :-)

My opinion : concentrate on public section with a distinct stylesheet. Make clean and minimalistic HTML, clean CSS. That's the only way (I think) to encourage people to create new templates (in the future, this should only be modified stylesheet and icon set) : in previous branchs there has not been many available templates (but in 1.2, because it was only a set of 10 pictures to modify).

As you can see, I completely agree with chrisaga. If the template is available soon (before the end of august) we could work to make it default template for branch 1.5, couldn't we ?

Offline

 

#22 2005-08-15 01:56:07

yoDan
Member
France
2005-06-05
39

Re: Improved HTML and layout

Thanks for your support. I updated admin.tpl in order to use the new navbar style (with DLs). Other files in admin/ folder are unchanged, so only a few admin pages validate (the first one (almost empty) and the instruction page do validate :). I also used more consistent class names and IDs, fixed a tiny bug in picture.tpl and updated the "print" style accordingly.
As before, see it live at http://yo.dan.free.fr/PWG or get the code at http://yo.dan.free.fr/tmp/clear2.tgz.

So what next before 1.5?
I would suggest a discussion over the DOCTYPE (Transitional vs. Strict, HTML vs. XHTML). :))
Also, we need to make sure the pages (picture and category) are clean in any situations. For instance, when looking for XHTML code in PWG PHP codebase, I found several "<br />", "style=", "class=" or "<[a-z]". This is inevitable, as it would make things overly complicated to avoid it completely. But it should be cleaned up (I looked at picture.php and it seems to produce a <BR /> soup instead of a UL, for instance).

Offline

 

#23 2005-08-16 20:53:16

chrisaga
Former Piwigo Team
France (92)
2005-08-10
543

Re: Improved HTML and layout

Hi yoDan
I've done some work too.
Based on your previous dclear template, i've a quite working environement.

about.tpl,
admin.tpl,
category.tpl,
identification.tpl,
profile.tpl

are now rewritten. They are more css based, HTML 4.01 Strict, and CSS valid :-)

Note : only the admin/help.tpl is done, the other admin/*.tpl are not rewritten yet, so only admin->user and admin->instruction can validate

They are table free, except for the table of users in profile.tpl which seems a legitimate table to me.

I've tested with firefox 1.06, Opera v7.54 u2, and IE 6.0 on linux (IE running under wine of course ;-)
Everything works fine except a little misalignement on the preference form under Opera.

It looks very similar to original clear template.

Still to do :
comment.tpl, register.tpl, search.tpl and upload.tpl and the remaining admin/*.tpl which are functional but not good looking.
I've no done any work on install.tpl and upgrade.tpl. It might be worth.
Of course much cleanning (get rid of old css definitions, class and id naming consistency, ...)

You cannot look at it live since I play in my home "sandbox" before releasing it on my site but you can download it at http://www.cepatre.net/tmp/cclear.tgz
(Ididn't modify your include/functions_html.inc.php)

I suggest you take  a look, and if you like it, we could merge our works (I didn't know you were working on it) and finish it.

I think category.tpl and picture.tpl must be improved :
* there is an alignement issue with long category names in category.tpl,
* picture.tpl is still table based (I must port my 1.3 branch tamplate to solve this one)


cepatre.net
Utilisateur depuis la version 1.3, Impliqué depuis la 1.4, Responsable du template des 1.5 et 1.6  ... et en (in)disponibilité sur la 1.7. J'ai fait l'impasse, et j'ai sauté directement en 2.2.2 !

Offline

 

#24 2005-08-17 02:46:00

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13789

Re: Improved HTML and layout

yoDan wrote:

So what next before 1.5?

Branch 1.5 comes with many modifications in template "default" while you are currently working on branch 1.4 (I propose a solution further in my post)

yoDan wrote:

I would suggest a discussion over the DOCTYPE (Transitional vs. Strict, HTML vs. XHTML). :))

May I let you (yoDan and chrisaga) decide about that ? I would say that HTML strict is better than XHTML transitional, but you're the boss.

yoDan wrote:

Also, we need to make sure the pages (picture and category) are clean in any situations.

There are very few differences in development branch since release 1.4.0 (last fork point) :

- revisions log for picture.tpl
- revisions log for category.tpl

yoDan wrote:

(I looked at picture.php and it seems to produce a <BR /> soup instead of a UL, for instance).

You're right, it's about the list of categories associated to the displayed picture. Obviously, ul/li should be used instead of stupid br. Add a CSS class "ul.associatedCategories" if you need it.

I see you and chrisaga working simultaneously on the template and you got poor tools to do this. Wouldn't it be cool to work directly in CVS (goal : clear template release 3 = default 1.5 template) ?

Offline

 

#25 2005-08-17 09:02:29

chrisaga
Former Piwigo Team
France (92)
2005-08-10
543

Re: Improved HTML and layout

Quick answer before going to work ;-)

z0rglub wrote:

yoDan wrote:

I would suggest a discussion over the DOCTYPE (Transitional vs. Strict, HTML vs. XHTML). :))

May I let you (yoDan and chrisaga) decide about that ? I would say that HTML strict is better than XHTML transitional, but you're the boss.

I think yoDan konws these matters better than me and I've nothing against HTML strict so let's make it the boss of DOCTYPE  ;-)

z0rglub wrote:

I see you and chrisaga working simultaneously on the template and you got poor tools to do this. Wouldn't it be cool to work directly in CVS

Great ! i've never done that before (since i used older versioning systems on AIX) but I'm on board. Just tell us where to start.

z0rglub wrote:

(goal : clear template release 3 = default 1.5 template) ?

Maybe people could use a knew template on 1.4 branch before 1.5 is released, and maybe after since everybody won't upgrade à once.

z0rglub wrote:

There are very few differences in development branch since release 1.4.0 (last fork point) :

- revisions log for picture.tpl
- revisions log for category.tpl

So it'll be possible to have the template work with both branches

Last thing : i think that you won't have to switch from the current default look to the clear one because it'll be very easy to port the colors and backgrounds on the new template.


cepatre.net
Utilisateur depuis la version 1.3, Impliqué depuis la 1.4, Responsable du template des 1.5 et 1.6  ... et en (in)disponibilité sur la 1.7. J'ai fait l'impasse, et j'ai sauté directement en 2.2.2 !

Offline

 

#26 2005-08-17 19:45:44

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13789

Re: Improved HTML and layout

chrisaga wrote:

z0rglub wrote:

I see you and chrisaga working simultaneously on the template and you got poor tools to do this. Wouldn't it be cool to work directly in CVS

Great ! i've never done that before (since i used older versioning systems on AIX) but I'm on board. Just tell us where to start.

- create an account on Gna! and ask to join PhpWebGallery project on the member list page

- read a documentation about CVS. For example, here is a documentation I wrote at my work (french, iso-8859-1)

- take a look at Branch and releases page on wiki

- retrieve a CVS working copy (follow indications from PhpWebGallery CVS page on Gna!). As branch 1.5 is our goal, take the HEAD branch (no -r option for checkout).

The decision to take is "how do we work" ? On a separate "clear" template ? Directly on the very soon obsolete "default" template ? Do you add template "clear" on branch-1_4, finalize it and then work on its adaptation to BSF (for next branch-1_5) ?

chrisaga wrote:

Maybe people could use a knew template on 1.4 branch before 1.5 is released, and maybe after since everybody won't upgrade à once.

I think we should concentrate on branch 1.5, which should be out in september. Developping now a new great template in branch 1.4 would be a kind of waste I think.

z0rglub wrote:

Last thing : i think that you won't have to switch from the current default look to the clear one because it'll be very easy to port the colors and backgrounds on the new template.

The current default look is one thing, not very important, in my opinion. The new template should make it very easy to change colors :-) (which is the main difference between template "clear" and "default", with user comments).

Offline

 

#27 2005-08-17 20:12:53

chrisaga
Former Piwigo Team
France (92)
2005-08-10
543

Re: Improved HTML and layout

Thanks for the explanations, i'll do that.

z0rglub wrote:

The decision to take is "how do we work" ? On a separate "clear" template ? Directly on the very soon obsolete "default" template ? Do you add template "clear" on branch-1_4, finalize it and then work on its adaptation to BSF (for next branch-1_5) ?

I asume that you'd suggest to go for the new default template on BSF.

* First if I do that, it would break the CVS untill every evolution between 1.4 and BSF template are integrated. Is this OK ? Are many people testing the BSF ?
* In the other hand, yoDan did modifications on include/functions_html.inc.php as far as I've checked they don't break the other templates but he suggested there might be others so the default template well be touched.
* Finally I'll be on hollydays from 3rd to 24 of September very far away from my computer and very busy to take pictures to feed my PhpWebGallery. So if the job isn't finished I hope yoDan or somebody could step up.

Could we work on a template "clear" for BSF and then switch to the new default, with old colors and theme or "clear" ones .

While you think, i'm going to set up my sandbox - sorry, my working environement - to play with BSF


cepatre.net
Utilisateur depuis la version 1.3, Impliqué depuis la 1.4, Responsable du template des 1.5 et 1.6  ... et en (in)disponibilité sur la 1.7. J'ai fait l'impasse, et j'ai sauté directement en 2.2.2 !

Offline

 

#28 2005-08-17 20:19:27

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13789

Re: Improved HTML and layout

chrisaga wrote:

Could we work on a template "clear" for BSF and then switch to the new default, with old colors and theme or "clear" ones .

Yes, I think it's the best to do.

chrisaga wrote:

Are many people testing the BSF ?

No, it seems not. I have no real feedback on it since many months. But I know BSF builds are downloaded (hundred times).

chrisaga wrote:

* Finally I'll be on hollydays from 3rd to 24 of September very far away from my computer and very busy to take pictures to feed my PhpWebGallery. So if the job isn't finished I hope yoDan or somebody could step up.

I think yoDan (that I know in the real life) is also taking holidays very soon and won't be connected. Anyway, I can maintain the template if the biggest work is down.

Offline

 

#29 2005-08-17 22:40:17

chrisaga
Former Piwigo Team
France (92)
2005-08-10
543

Re: Improved HTML and layout

OK I've a working BSF sandbox (please zorglub see the install bug I reported).
I can start building the new template from my previous work ...
But not tonight ;-)


cepatre.net
Utilisateur depuis la version 1.3, Impliqué depuis la 1.4, Responsable du template des 1.5 et 1.6  ... et en (in)disponibilité sur la 1.7. J'ai fait l'impasse, et j'ai sauté directement en 2.2.2 !

Offline

 

#30 2005-08-17 23:08:44

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13789

Re: Improved HTML and layout

chrisaga wrote:

(please zorglub see the install bug I reported).

bug squashed

Offline

 
  •  » Requests
  •  » Improved HTML and layout

Board footer

Powered by FluxBB

github twitter newsletter Donate Piwigo.org © 2002-2024 · Contact