Piwigo.org

plg · 2013-12-16 10:08:54

Hi,

2 users have reported me the same bug in less than 7 days: suddenly they can't see sub-albums. Sub-albums visibility is correctly configured. The problem I've found is that user_cache_categories is wrong.

For example:

Code:

mysql>  select id, name, id_uppercat, uppercats from categories where id_uppercat=32;
+-----+------------------------+-------------+-----------+
| id  | name                   | id_uppercat | uppercats |
+-----+------------------------+-------------+-----------+
| 164 | Vatican 2005           |          32 | 29,32,164 |
| 165 | Place d'Espagne 2011   |          32 | 29,32,165 |
| 166 | Villa Borghese 2011    |          32 | 29,32,166 |
| 167 | Forum Romano 2005      |          32 | 29,32,167 |
| 168 | Piazza del Popolo 2005 |          32 | 29,32,168 |
| 169 | Trastevere 2005        |          32 | 29,32,169 |
| 298 | Muse Capitole 1994     |          32 | 29,32,298 |
| 299 | Pont Sisto 1994        |          32 | 29,32,299 |
+-----+------------------------+-------------+-----------+
8 rows in set (0.00 sec)

and:

Code:

mysql> select * from user_cache_categories where user_id=1 and cat_id=32;
+---------+--------+-----------+---------------+-----------+--------------+------------------+--------------------------------+
| user_id | cat_id | date_last | max_date_last | nb_images | count_images | count_categories | user_representative_picture_id |
+---------+--------+-----------+---------------+-----------+--------------+------------------+--------------------------------+
|       1 |     32 | NULL      | NULL          |         0 |            0 |                0 |                           NULL |
+---------+--------+-----------+---------------+-----------+--------------+------------------+--------------------------------+
1 row in set (0.00 sec)

then I create a new album at the root of the gallery and delete it (just to force reset on user cache), I refresh on gallery side, and :

Code:

mysql> select * from user_cache_categories where user_id=1 and cat_id=32;
+---------+--------+-----------+---------------------+-----------+--------------+------------------+--------------------------------+
| user_id | cat_id | date_last | max_date_last       | nb_images | count_images | count_categories | user_representative_picture_id |
+---------+--------+-----------+---------------------+-----------+--------------+------------------+--------------------------------+
|       1 |     32 | NULL      | 2013-12-15 12:19:01 |         0 |           64 |                8 |                           5265 |
+---------+--------+-----------+---------------------+-----------+--------------+------------------+--------------------------------+
1 row in set (0.00 sec)

rvelices (who has worked on user cache), do you have an idea?

plg · 2013-12-16 11:06:39

One user tells me that he has created albums from Lightroom and that it oftens produces an error. He will give me more details about the error message in Lightroom.

rvelices · 2013-12-16 11:17:35

plg wrote:
rvelices (who has worked on user cache), do you have an idea?

Many ws functions do not call invalidate_user_cache (directly or indirectly). Examples:
ws_add_image_category_relations
ws_images_addSimple

plg · 2013-12-16 11:19:55

I've used pwg.images.addSimple so many times with no problem that I can't believe it is the origin of the problem. I'll make test and fix it! Thank you.

rvelices · 2013-12-16 13:15:20

And I just realized the new user manager will not improve things as web service calls never invalidate user cache ...

plg · 2013-12-16 13:35:21

OK, you're right!

plg · 2013-12-16 14:05:07

ws_images_addSimple() calls add_uploaded_file() which calls invalidate_user_cache()

ws_add_image_category_relations() is called by:
* ws_images_setInfo() which calls invalidate_user_cache() at its end
* ws_images_add() which calls invalidate_user_cache() at its end

plg · 2013-12-16 16:10:37

[Subversion] r25968

bug 3012 fixed: invalidate_user_cache() on pwg.users.setInfo, pwg.groups.addUser, pwg.groups.deleteUser

plg · 2013-12-17 10:05:04

[Subversion] r25975 by rvelices : adds invalidate_user_cache() on pwg.groups.delete (+ smarter call of invalidate_user_cache())

plg · 2013-12-17 10:06:27

The user has reported the problem occuring with Lightroom. I have completed it with server logs and sent it to Vladimir (alloyphoto)

Piwigo.org

Announcement

#1 2013-12-16 10:08:54

bug in user_cache_categories

Code:

Code:

Code:

#2 2013-12-16 11:06:39

Re: bug in user_cache_categories

#3 2013-12-16 11:17:35

Re: bug in user_cache_categories

plg wrote:

#4 2013-12-16 11:19:55

Re: bug in user_cache_categories

#5 2013-12-16 13:15:20

Re: bug in user_cache_categories

#6 2013-12-16 13:35:21

Re: bug in user_cache_categories

#7 2013-12-16 14:05:07

Re: bug in user_cache_categories

#8 2013-12-16 16:10:37

Re: bug in user_cache_categories

#9 2013-12-17 10:05:04

Re: bug in user_cache_categories

#10 2013-12-17 10:06:27

Re: bug in user_cache_categories

Board footer