Piwigo.org

You are not logged in. (Register / Login)

Announcement

#1 2017-07-04 13:02:41

P@t
Piwigo Team
Location: Nice
Registered: 2007-06-13
Posts: 4098
Website

[Theme] Bootstrap Darkroom - Carousel problem

Hi teekay,

I found a problem with the carousel. If the carousel is enabled with this values:
- lazyLoad method : on demand
- Infinite looping : No
- Center mode : No

Only the last 3 photos are displayed in the carousel when you select one of this 3 photos.

PS: This theme is really great... good job!!
Maybe you could add an option to select link's numbers in breadcrums... (I modified strip_breadcrumbs function because I need 3 levels of links in breadcrumbs). But this option can be integrated in piwigo core...


Uploaded Images


P@t

Offline

 

#2 2017-07-04 14:25:40

teekay
Member
Registered: 2013-06-12
Posts: 253

Re: [Theme] Bootstrap Darkroom - Carousel problem

Hi P@t,

hm, I can't reproduce the Slick carousel issue. Does it work for you on the Demo?
https://pwgdemo.kuther.net/picture/57-o … /3-flowers
The settings are the same there, now: no center, no looping

The strip_breadcrumbs function is quite a mess. I wish there was a setting for this in core or any other means of improving the handling of TITLE/SECTION_TITLE

Offline

 

#3 2017-07-04 14:39:40

plg
Piwigo Team
Location: Nantes, France, Europe
Registered: 2002-04-05
Posts: 13038
Website

Re: [Theme] Bootstrap Darkroom - Carousel problem

teekay wrote:

I wish there was a setting for this in core or any other means of improving the handling of TITLE/SECTION_TITLE

I'm OK with it. For next Piwigo version I can add a configuration setting for the number of album levels to display in the breadcrumb.


Latest blog post (March 23th 2017) Piwigo.com Enterprise plans, now official!

Offline

 

#4 2017-07-04 15:02:06

P@t
Piwigo Team
Location: Nice
Registered: 2007-06-13
Posts: 4098
Website

Re: [Theme] Bootstrap Darkroom - Carousel problem

Hum... no problems on the demo....
You can see the problem here:
https://www.gauchon.fr/picture/8054/category/654


P@t

Offline

 

#5 2017-07-04 15:16:17

teekay
Member
Registered: 2013-06-12
Posts: 253

Re: [Theme] Bootstrap Darkroom - Carousel problem

P@t wrote:

Hum... no problems on the demo....
You can see the problem here:
https://www.gauchon.fr/picture/8054/category/654

Hmm, it only affects the last three pictures in the album. I'll see if I can reproduce it on my site.

plg wrote:

teekay wrote:

I wish there was a setting for this in core or any other means of improving the handling of TITLE/SECTION_TITLE

I'm OK with it. For next Piwigo version I can add a configuration setting for the number of album levels to display in the breadcrumb.

That would be great. Though for the theme I could need different levels for different devices/screen resolutions.
Lots of  code exists for replacing the home link text with an icon, too. So, a more flexible way to build the breadcrumbs would be perfect. Like split (SECTION_)TITLE into HOME_LINK, CATEGORY_PATH (with levels) AND IMAGE_TITLE, something like that

Last edited by teekay (2017-07-04 15:24:11)

Offline

 

#6 2017-07-05 18:41:57

ZeBe
Member
Location: Bavaria
Registered: 2017-06-06
Posts: 13

Re: [Theme] Bootstrap Darkroom - Carousel problem

@teekay

I have the same problem with the carousel.
You can reproduce it on P@t's website when you go to a category with more than 35??? pictures and then select the last picture of the category. Then you will get the strange behaviour that the first pictures of the carousel are not displayed.

35 Pictures:
https://www.gauchon.fr/index/category/75

42 Pictures
https://www.gauchon.fr/index/category/664

On the demo site everything works but it seems that the demo site is on a fast server.


Plugin for Category
  GThumb+

    Piwigo 2.9.1
    Betriebssystem: Linux
    PHP: 7.0.19 (Info anzeigen) [2017-07-05 16:39:13]
    MySQL: 5.6.30 [2017-07-05 18:40:06]
    Grafikbibliothek: ImageMagick 6.7.7-10

Offline

 

#7 2017-07-05 23:04:03

teekay
Member
Registered: 2013-06-12
Posts: 253

Re: [Theme] Bootstrap Darkroom - Carousel problem

It does sound like [Github] slick issue #2173

I'll put a patched version of slick in a test branch, soon.

Offline

 

#8 2017-07-05 23:46:13

teekay
Member
Registered: 2013-06-12
Posts: 253

Re: [Theme] Bootstrap Darkroom - Carousel problem

OK, here is a version with that patch applied.

You can try to replace themes/bootstrap_darkroom/components/slick-carousel/slick/slick.min.js with the one from https://raw.githubusercontent.com/tkuth … ick.min.js

Offline

 

#9 2017-07-06 16:08:30

ZeBe
Member
Location: Bavaria
Registered: 2017-06-06
Posts: 13

Re: [Theme] Bootstrap Darkroom - Carousel problem

Your patch solves the problem.
Now all thumbnails in carousel are displayed.
Sometimes it took some time (2-5s) until all are display but i think this depends on the performance of the server to generate the thumbnails.

Many thanks for your effort.

Greetings
ZeBe

PS: I like Bootstrap Darkroom Theme

Offline

 

#10 2017-07-07 09:40:29

teekay
Member
Registered: 2013-06-12
Posts: 253

Re: [Theme] Bootstrap Darkroom - Carousel problem

Great it works now.

Does it take 2-5 seconds each time you access the page, or only the first time? Once generated, the thumbnails should be cached.

Offline

 

#11 2017-07-07 18:04:53

ZeBe
Member
Location: Bavaria
Registered: 2017-06-06
Posts: 13

Re: [Theme] Bootstrap Darkroom - Carousel problem

Is is only the first time when i access the page.

Offline

 

#12 2017-07-11 00:15:17

P@t
Piwigo Team
Location: Nice
Registered: 2007-06-13
Posts: 4098
Website

Re: [Theme] Bootstrap Darkroom - Carousel problem

It's work perfectly with your patch.
Thanks!


P@t

Offline

 

Board footer

Powered by FluxBB

github twitter facebook google+ newsletter Donate Piwigo.org © 2002-2017 · Contact