As far as I understand, you're introducing a new feature here : the ability to have a another domain. A place where overloading is not possible. Right?

I admit I don't clearly see the advantage :-/ Can you give an example?

nicolas wrote:

plg wrote:

I admit I don't clearly see the advantage :-/ Can you give an example?

If you have another idea you're welcome.

I have absolutely no idea about this. I just wonder if 1) we can't overload strings in gettext system or 2) adding the namespace feature is necessary. I just don't know.

VDigital wrote:

Many plugins in WordPress are designed to use a domain for local translation.
As I understand it will be fine for Plugins and any .tpl (templates or template-extensions or templates file embeded in a plugin).

My proposition solve problem of local gettext files in plugins and also for template even if I think it's not the right place (template) to put local language files. But you can do it. Happy ?

rvelices wrote:

Nicolas,
I think you need to pass the domain from the .tpl in plugins .... ( A template can include another, a plugin can change the template from the core so I think there is no way to find the domain just from <p>{'A string to translate from my plugin'|@local_translate}</p> ... because the execution of the rendering is delayed ... )

I would rather see something like
mod_translate(($key, $domain = "piwigo" )

and from my plugin rv_gmaps I would say
{'Maps'|@translate:'rv_gmaps'}

Thanks, I'll appreciate your advices. I know there's no way to find the correct domain, so I have proposed a new method for plugins (and what else ?) to give theses informations

  public function setPluginConf($textdomain, $path) 
  {
    $this->plugin['textdomain'] = $textdomain;
    $this->plugin['path'] = $path;
  }

In my plugin, I can do somethink like that :

$template->set_filenames(array('plugin_admin_content' => MY_PLUGIN_TEMPLATE . '/admin.tpl'));
$template->setPluginConf('messages', 'path/to/plugin/language/directory');
$template->assign_var_from_handle('ADMIN_CONTENT', 'plugin_admin_content');

And in my plugin template, I can use my local strings with local_translate and strings for piwigo core with translate.


I didn't understand how do you find the right piwigo.po file with your proposition.

rvelices wrote:

I would rather see something like
mod_translate(($key, $domain = "piwigo" )

and from my plugin rv_gmaps I would say
{'Maps'|@translate:'rv_gmaps'}

I like this idea... but... in {'Maps'|@translate:'rv_gmaps'}, what is 'rv_gmaps'? Is it directory name of the plugin?
Be careful with that.. if a plugin developper add plugin's files in the root of the archive (in PEM) without plugin subdirectory, the automatic installationof plugin manager will create arbitrary directory like extension-250.