plg wrote:
1) agree with nicolas that the language key should be the English value.
grum wrote:
If the key have to be changed ? grammar errors, wording, sentence building...
The "english key" have an English translation or the key is directly used ?
By migrating my templates to the 'themes' system, I see I have all the {"................"|@translate} to modify in the .tpl files...
Offline
grum wrote:
By migrating my templates to the 'themes' system, I see I have all the {"................"|@translate} to modify in the .tpl files...
I'm not sure to understand your problem or your question.
I have to revert all commits about gettextI made on trunk. But I think it could be a good idea to keep english value for language key. So I will not revert templates.
Offline
nicolas wrote:
I have to revert all commits about gettextI made on trunk. But I think it could be a good idea to keep english value for language key. So I will not revert templates.
If you do not, all overridden keys will be lost on upgrade. This is a bad idea. Full rollback is better IMO.
Mathias
Offline
nicolas wrote:
grum wrote:
By migrating my templates to the 'themes' system, I see I have all the {"................"|@translate} to modify in the .tpl files...
I'm not sure to understand your problem or your question.
For example, picture_nav_buttons.tpl was broken with gettext.
I corrected that in commit 5115.
Maybe another files were broken...
mathiasm wrote:
If you do not, all overridden keys will be lost on upgrade. This is a bad idea. Full rollback is better IMO.
+1
Offline
mathiasm wrote:
nicolas wrote:
I have to revert all commits about gettextI made on trunk. But I think it could be a good idea to keep english value for language key. So I will not revert templates.
If you do not, all overridden keys will be lost on upgrade. This is a bad idea. Full rollback is better IMO.
Mathias
Can you provide me an example to help me understand the problem. For me there's no problem but I can miss something.
P@t wrote:
For example, picture_nav_buttons.tpl was broken with gettext.
I corrected that in commit 5115.
Maybe another files were broken.
No. It's no the same problem. My script that change key in templates by english values was buggy and it also replace image name and such things !
Offline
matiasm wrote:
If you do not, all overridden keys will be lost on upgrade. This is a bad idea. Full rollback is better IMO.
So, for now I don't do anything on my 2.1 themes : I keep the "old" translation keys until the definitive translation system is choosen.
Offline
Hi,
First of all thank you for the script, its is very good, simple to use and very flexible!
I am new in this....please sorry if what i am asking is a "silly question"...
I have a problem in my site when i try to change the translation of a word in Spanish (es_AR). In the menu the translation was wrong said: "Agregar una imagem" instead of ""Agregar una imagen", i change the m for a n in the file: language/es_AR/common.lang.php. Then in the site give me this error:
"Warning: Cannot modify header information - headers already sent by (output started at /home2/masefici/public_html/vestidadefiesta/language/es_AR/common.lang.php:1) in /home2/masefici/public_html/vestidadefiesta/include/page_header.php on line 98"
I try to get back the change made but the error message not disappear....
If you can take a look to the site to see what i said: www.vestidadefiesta.com
thanks in advance
Sebastian.-
be careful, You mustn'tforgetten ' in the end
This gives
$lang['upload_picture'] = 'Agregar una imagen';
Offline
ddtddt wrote:
be careful, You mustn'tforgetten ' in the end
This gives
$lang['upload_picture'] = 'Agregar una imagen';
Dear ddtddt,
Thanks for your fast answer.
I made the change in the common.lang.php file but the problem continue, where i must do the changes?
thanks in advance.
Sebastián.-
You can download the corrected file here:
http://piwigo.org/svn/branches/2.0/language/es_AR/
If the error persists is that it comes from other
Offline
ddtddt wrote:
You can download the corrected file here:
http://piwigo.org/svn/branches/2.0/language/es_AR/
If the error persists is that it comes from other
OK thanks, i will try.
Sebastian wrote:
ddtddt wrote:
You can download the corrected file here:
http://piwigo.org/svn/branches/2.0/language/es_AR/
If the error persists is that it comes from otherOK thanks, i will try.
The file work OK!
Thanks again
Sebastian wrote:
The file work OK!
Thanks again
Thanks, you've report error ;-)
You can also participate in the Spanish forum
Offline