Piwigo.org

grum · 2010-04-03 14:49:24

I'm updating my template Gally.

And I don't understand why all the comment are encapsuled in a <div> because there is nothing like that in the tpl file.

Finally, I found this function, called by a trigger before the {$comment.CONTENT} is affected to the template.

Code:

/* file : functions_html.inc.php, line 179 */
function parse_comment_content($content)
{
 [...]
  $content = '<div>'.$content.'</div>';
  return $content;
}

the <div> are absolutely necessary ?
Or can we remove them ?

If the comment have to be encapsuled in a <div>, normaly it must be done in the tpl file.

mathiasm · 2010-04-03 19:14:30

I didn't find this div when looking at source of http://piwigo.org/demo/picture.php?/23/category/Asia

Code:

<div id="comments">
    <h3>6 commentaires</h3>
<ul class="thumbnailCategories">
<li>
  <div class="thumbnailCategory even">
    <div class="description">
      <span class="author">popaj</span> - <span class="date">Vendredi 12 Janvier 2007 15:27</span>
      <blockquote><div>sta os</div></blockquote>
    </div>
  </div>
</li>
<hr/>

But i agree all the html should be in the template.

grum · 2010-04-03 19:43:33

you didn't look well...

<blockquote><div>sta os</div></blockquote>

these <div> are not in the template.

Last edited by grum (2010-04-03 19:43:55)

nicolas · 2010-04-03 20:40:24

grum wrote:
you didn't look well...

<blockquote><div>sta os</div></blockquote>
these <div> are not in the template.

There's others problems in the parse_comment_content() function. There's many inline css style. Inline style avoid overriding style in an external stylesheet for example.

mathiasm · 2010-04-04 00:50:42

I missed it completely.

Maybe we should enter a bug in mantis to fix that.

grum · 2010-04-05 22:42:28

yes, I do it in mantis ([Bugtracker] ticket 1580) and do commit.

Last edited by grum (2010-04-05 22:47:08)

JashimChando · 2010-05-19 08:53:41

Hi

I also same opinion with bug enter a bug in mantis to fix that.

Thanks

Piwigo.org

Announcement

#1 2010-04-03 14:49:24

the comments

Code:

#2 2010-04-03 19:14:30

Re: the comments

Code:

#3 2010-04-03 19:43:33

Re: the comments

#4 2010-04-03 20:40:24

Re: the comments

grum wrote:

#5 2010-04-04 00:50:42

Re: the comments

#6 2010-04-05 22:42:28

Re: the comments

#7 2010-05-19 08:53:41

Re: the comments

Board footer