Announcement

  •  » Engine
  •  » new plugin require changes to core theme

#1 2010-12-30 16:43:10

rvelices
Piwigo Team
2005-12-29
1960

new plugin require changes to core theme

I'm preparing a new plugin that will load thumbnails on the index page using ajax as the user scrolls down the page. However it will not work, unless I make the following changes to the core theme
- move category description before thumbnails (it is after now)
- move the enclosing <ul></ul> from thumbnails.tpl to index.tpl

Are you ok with these 2 changes ?

Offline

 

#2 2010-12-30 17:03:14

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13603

Re: new plugin require changes to core theme

This would be a great plugin. A "river". No more pagination on the album page and that's really cool!

- move category description before thumbnails (it is after now)

This change can't be done with a smarty prefilter?

Personally, I don't think it's a problem at all to have the album description on top, before thumbnails. I even really like the way gally themes are displaying the description : on the left. But maybe some users want nothing before their thumbnails, I don't know.

Offline

 

#3 2010-12-30 17:05:33

rvelices
Piwigo Team
2005-12-29
1960

Re: new plugin require changes to core theme

Prefilter could work but any child theme that redefines index.tpl and changes something that I could not match will fail...
I'll make the changes and then we'll see ...

Offline

 

#4 2010-12-30 17:09:07

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13603

Re: new plugin require changes to core theme

rvelices wrote:

I'll make the changes and then we'll see ...

OK.

I have no idea of the impact of moving the <ul></ul> to index.tpl

Offline

 

#5 2010-12-30 17:12:30

rvelices
Piwigo Team
2005-12-29
1960

Re: new plugin require changes to core theme

plg wrote:

I have no idea of the impact of moving the <ul></ul> to index.tpl

Nothing except all child themes must do it ... But if they do it, the plugin will work with any theme ...

Offline

 

#6 2010-12-30 17:19:40

grum
Former Piwigo Team
Pantin
2007-09-10
1371

Re: new plugin require changes to core theme

plg wrote:

I even really like the way gally themes are displaying the description : on the left.

On gally theme, desc can be :
- on the left
- on the top
- on the bottom
(all combination are possibles)

And think about [extension by Piwigo Team] Extended Description : it's possible to move desc on the top and/or on the bottom.


I'm not sure to understand why it's necessary to change the core, but if you think that making theses changes can be a good thing for piwigo, why not...


My pictures with Piwigo, of course !
[ www.grum.fr ]

Offline

 

#7 2010-12-30 21:04:30

rvelices
Piwigo Team
2005-12-29
1960

Re: new plugin require changes to core theme

Offline

 

#8 2010-12-31 15:29:56

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13603

Re: new plugin require changes to core theme

The feature is great (goodbye pagination), but :

1) the loading icon is ugly :-/ => http://www.modusoptimus.com/pwg/plugins … loader.gif
what about this one http://le-gall.net/pierrick/images/ajax-loader-01.gif or http://le-gall.net/pierrick/images/ajax-loader-02.gif I've found them on http://ajaxload.info/

2) it doesn't work on iPhone (but it works on MacOs Safari on my MacBook and also on Android even if I don't see the loading icon)

Offline

 

#9 2010-12-31 16:28:55

rvelices
Piwigo Team
2005-12-29
1960

Re: new plugin require changes to core theme

plg wrote:

2) it doesn't work on iPhone (but it works on MacOs Safari on my MacBook and also on Android even if I don't see the loading icon)

Do you now if I cant test the IPhone online with some emulator?

Offline

 

#10 2010-12-31 16:31:50

rvelices
Piwigo Team
2005-12-29
1960

Re: new plugin require changes to core theme

plg wrote:

The feature is great (goodbye pagination)

In fact after N reloads, we fall back to the pagination mode - otherwise it is impossible to go to the end of 10000 pictures and your browser will have memory/performance issues.

Great site ... I'll play with it

Offline

 

#11 2010-12-31 16:36:54

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13603

Re: new plugin require changes to core theme

rvelices wrote:

plg wrote:

2) it doesn't work on iPhone (but it works on MacOs Safari on my MacBook and also on Android even if I don't see the loading icon)

Do you now if I cant test the IPhone online with some emulator?

No, I don't know. I notify P@t, he may have an idea.

Offline

 

#12 2010-12-31 17:50:43

P@t
Piwigo Team
Nice
2007-06-13
4098

Re: new plugin require changes to core theme

rvelices wrote:

plg wrote:

2) it doesn't work on iPhone (but it works on MacOs Safari on my MacBook and also on Android even if I don't see the loading icon)

Do you now if I cant test the IPhone online with some emulator?

You can test on MAC OS with xCode and iPhone SDK.


P@t

Offline

 
  •  » Engine
  •  » new plugin require changes to core theme

Board footer

Powered by FluxBB

github twitter newsletter Donate Piwigo.org © 2002-2022 · Contact