•  » Extensions
  •  » [resolved] Embedded Videos uses MyISAM rather than default storage engine

#1 2014-07-22 18:55:36

philb
Member
2014-07-22
30

[resolved] Embedded Videos uses MyISAM rather than default storage engine

I recently installed the embedded videos plugin and noticed upon inspecting my database that it had created a MyISAM table.

I had a look in the source and see the hard coded MyISAM engine selection:

    // create table
  $query = '
CREATE TABLE IF NOT EXISTS `' . $this->table . '` (
  `picture_id` mediumint(8) NOT NULL,
  `url` varchar(255) DEFAULT NULL,
  `type` varchar(64) NOT NULL,
  `video_id` varchar(128) NOT NULL,
  `width` smallint(9) DEFAULT NULL,
  `height` smallint(9) DEFAULT NULL,
  `autoplay` tinyint(1) DEFAULT NULL,
  `embed` text DEFAULT NULL
) ENGINE=MyISAM DEFAULT CHARSET=utf8
;';
    pwg_query($query);

Innodb has been the default storage engine for MySQL since 2010, perhaps you could consider removing the engine definition and allow the default storage engine to be used?

Fortunately I discovered this before I had started using the plugin. MyISAM is rather unreliable when using clustering software like Galera.

Last edited by philb (2014-07-22 18:57:00)

Offline

 

#2 2014-07-22 18:58:16

mistic100
Former Piwigo Team
Lyon (FR)
2008-09-27
3277

Re: [resolved] Embedded Videos uses MyISAM rather than default storage engine

Hi

Every Piwigo table is MyISAM, not only Embedded Videos
http://piwigo.org/dev/browser/trunk/ins … -mysql.sql

I won't debate with you on this choice because I don't have any knowledge on the subject

--

edit: everywebsite I read state that InnoDB is slower (for read operations) and heavier than MyISAM, that certainly why we force MyISAM

Offline

 

#3 2014-07-22 19:02:27

philb
Member
2014-07-22
30

Re: [resolved] Embedded Videos uses MyISAM rather than default storage engine

Ah, I didn't realise that - When I first installed Piwigo a couple of years ago I probably converted all the tables as all my tables are Innodb!

Offline

 
  •  » Extensions
  •  » [resolved] Embedded Videos uses MyISAM rather than default storage engine

Board footer

Powered by FluxBB

github twitter newsletter Donate Piwigo.org © 2002-2024 · Contact