2.7 test results:
* Themes - GD theme has been converted/verified and I did not find big issues, all but admin section...
* Admin section - changes applied to left side navigation menu are such that they do not allow to determine via css if section is expanded/collapsed as it was before using .ui-accordion
It would be very useful if along with modifying visibility of UL element, some sort of class would be set to section header section. In fact, if you do that then visibility would be maintained automatically based on simple hierarchy like dt.active, dt.active+dd
I know Piwigo does not promote styling of admin section, but having more class attributes set in 2.6 was handy
* Use of themeconf[colorscheme] - this is global setting, while in fact it should be allowed to be set dynamically. Would it be safe to set it in add_event_handler('init', 'mytheme_init'); ?
Last edited by Serge D (2014-09-23 07:52:53)
Offline
the {$ACTIVE_MENU} template variable tells you which menu is open
--
yes no problem, it is intended to work that way
Offline
Serge D wrote:
* Use of themeconf[colorscheme] - this is global setting, while in fact it should be allowed to be set dynamically. Would it be safe to set it in add_event_handler('init', 'mytheme_init'); ?
just set it when themeconf.inc.php is loaded as here:
http://piwigo.org/dev/browser/trunk/the … nc.php#L13
Offline
rvelices wrote:
Serge D wrote:
* Use of themeconf[colorscheme] - this is global setting, while in fact it should be allowed to be set dynamically. Would it be safe to set it in add_event_handler('init', 'mytheme_init'); ?
just set it when themeconf.inc.php is loaded as here:
http://piwigo.org/dev/browser/trunk/the … nc.php#L13
themes could need to change it depending on which style is loaded (Stripped for example) :-)
Offline
even more dynamic if you have several styles in your theme :-)
http://piwigo.org/dev/browser/extension … nc.php#L63
'colorscheme' => 'white' == $stripped['themeStyle'] ? 'clear' : 'dark',
Offline
ok, this may work, need to test, but it breaks concept of using events
Offline