Published new version 2.9.d

Changelog:
- admin.php: check $_POST parameters prevent XSS attack if admin browser hijacked
- admin.php: check $_FILES extensions to be a picture on server side also
- admin.php: trying to prepare the folders for correct write permissions
- admin.php: replacing some plugin functions with some Piwigo ones from /admin/include/functions_upload.inc.php
- admin.php/admin.tpl: accepted file extensions are taken from the piwigo config
- admin.tpl: css fix figcaption word break for long file names

Nice work!

Just wanted to point out that when selecting files, the red INFO line always shows zeros for me:



It also looks like that area should show me thumbnails? I never see those like in your screenshot.

Also, when I was working on my version of the plugin (before you beat me to it, :-) ) I had added my UI to the Photos > Add area, instead of under the Plugins menu, thinking that made more sense. It looks like this:



I did that via this code in main.inc.php:

// add ppu tab to the Add Photos tabset
add_event_handler('tabsheet_before_select','ppu_add_tab');

function ppu_add_tab($sheets, $id)
{
  if ($id == 'photos_add')
  {
    $sheets['ppu'] = array(
      'caption' => '<span class="icon-floppy"></span>'.l10n('UPLOAD_TAB'),
      'url' => get_root_url().'admin.php?page=plugin-physical_photo_upload',
      );
  }

  return $sheets;
}

In case you're interested in putting yours there. Not sure what the Piwigo developer guidelines say about adding tabs to the main areas like that ...

Last edited by windracer (2018-02-17 00:03:45)

I've seen that you are not using a SVN/Git: that would allow our translators to .. well translate it
ad it would allow you to have an issue tracking, changelog and direct contribution from anyone on github that you could validate in one click

windracer wrote:

Just wanted to point out that when selecting files, the red INFO line always shows zeros for me:
http://piwigo.org/forum/showimage.php?p … o-zero.jpg
It also looks like that area should show me thumbnails? I never see those like in your screenshot.

1) Strange, never had such an error on Firefox. What browser do you use, what OS, using some plugins that block scripts? Can you show me a print screen of browser JS console to see if some error appear. Sorry but i need your console to see what is happening, if I can't reproduce.

2) I prefer my plugin to have it's own option page.

Hope you will also make your plugin public as an alternative to my plugin.

You're right, it works in Firefox, but not in Chrome, Edge, or Internet Explorer (for me). I was just testing with .JPG files. I'm not using any script blockers in Chrome and tried poking around in the Javascript console but didn't see any problems. I'll keep poking at it ...

The Mozilla code was working fine for Chrome. I found 2 very weird bugs in my extra JS code. Such weird that they didn't show any errors in Firefox or Chrome console. Is not easy to debug blindly.

First bug it was getting properties from DOM elements and not refreshing them on events change if you execute functions that use those properties. This is clearly a bug. I don't really understand why everything worked perfect in Firefox as getElementById is not live https://stackoverflow.com/questions/191 … om-element

Second bug was a typo mistake, an extra space to a variable before equal, I found very weird as made my javascript to not work anymore in Chrome and Chrome console didn't show any error ... damn.

Last edited by eliz82 (2018-02-19 19:16:41)

2.9.f is now broken. The image previews and info work in Chrome, but upload does not:

"Upload form is incomplete, please select an album and an image file"

I've tried selecting the album first, then images, and vice versa, same error. Also tried IE, same problem.