I enabled error reporting and found the following error:

Fatal error: Uncaught Error: Call to undefined function set_magic_quotes_runtime() in .../photos/install.php:29 which reads:

@set_magic_quotes_runtime(0); // Disable magic_quotes_runtime

set_magic_quotes_runtime was removed as of PHP 7.0.0.  I have no idea why they're not using mysql_real_escape_string, or how this runs for anyone.

So, I commented out that line, only to find that at line 34, it's calling:

if( !@get_magic_quotes_gpc() )

which was also removed from PHP, so I changed this to: if (false), as the code under that used slash functions that were also removed from PHP.

Then the code tries to use an undefined class (Template), which means that something is seriously wrong with the code, so I'm giving up. [Edit: Per my reading of the code, it should be defined, so this makes no sense.]

Is there someone from the development team who can explain what's going on here?

-- Geoff

Last edited by geoffschultz (2024-08-02 23:12:04)

The file that I unzipped was named piwigo-14.5.0.zip and came from this site.  When I run the install, the credentials window shows "14.5-0", so I believe that I have the right distribution.

However, when I compare the install.php in the zip file to the one on my server, they're different.  I edited the install.php on the server by right-clicking on it and view/edit on FileZilla, so I don't understand how they're different.  So, I'll delete the contents of /photo again, FTP the 14.5.0 zip file, and try again.

Last edited by geoffschultz (2024-08-03 12:03:41)

The following code, around line 315 in the install.php file, is incorrect.  The code under the first IF statement executes even if the fopen fails.  I changed it to

  $fp = @fopen( $config_file, 'w' );
  if (!($fp === false))

and it executes as expected.  However, the bottom 2 lines of the following need to be moved into the IF {}.

However, there's no error reporting if it can't write the config file!  With the above changes, the install completes, but with no config file, it just repeats trying to install.   

if ( !($fp = @fopen( $config_file, 'w' )))
    {
      // make sure nobody can list files of _data directory
      secure_directory(PHPWG_ROOT_PATH.$conf['data_location']);
     
      $tmp_filename = md5(uniqid(time()));
      $fh = @fopen( PHPWG_ROOT_PATH.$conf['data_location'] . 'pwg_' . $tmp_filename, 'w' );
        if (!($fh === false)) {
              @fputs($fh, $file_content, strlen($file_content));
              @fclose($fh);
        }

      $template->assign(
        array(
          'config_creation_failed' => true,
          'config_url' => 'install.php?dl='.$tmp_filename,
          'config_file_content' => $file_content,
          )
        );
    }
    @fputs($fp, $file_content, strlen($file_content));
    @fclose($fp);

Last edited by geoffschultz (2024-08-03 12:51:54)

geoffschultz wrote:

when I compare the install.php in the zip file to the one on my server, they're different.  I edited the install.php on the server by right-clicking on it and view/edit on FileZilla, so I don't understand how they're different.

My guess: you did not do a clean install from scratch but had an existing 2.4.3 files tree there and your upload procedure failed to overwrite existing files (or failed to write files at all), hence you still had the 2.4.3 code.