Piwigo.org

rub · 2008-10-16 07:45:25

Is it a will to remove this code:

Code:

    pwg_query($query);    
     $query = '    
 REPLACE INTO '.PLUGINS_TABLE.'    
   (id, state)    
   VALUES (\'c13y_upgrade\', \'active\')    
 ;';    
     pwg_query($query);

in [Subversion] r2754 ?

If yes, I would like to have discussed about it in the forum or at least that we remove it before 2.0.0 release candidates. It would have avoided questions from users and answers from me.

If we really remove it, no problem but we don't do only a half of it.

Last edited by z0rglub (2008-10-16 20:43:11)

plg · 2008-10-16 22:54:47

It's not a will. I've removed it because I had not a precise idea of what it was (there was no comment in the code). Can you give me more details please?

rub · 2008-10-17 07:55:04

[Forum, topic 11763]

At moment, c13y_upgrade check double email on user list and obsolete plugins (plugins integrated on core pwg).

But, this checks can be move to core pwg check list (exif test, status user,...) (check done on admin main page).

This plugin is activated only between upgrades.

rub · 2008-10-20 07:44:11

So, what we do?

I reintroduce c13y_upgrade to upgrade.php?
Or I introduce c13y_upgrade checks on core c13y checks?

rub · 2008-10-22 07:16:23

up?

plg · 2008-10-22 22:30:24

rub wrote:
I reintroduce c13y_upgrade to upgrade.php?

Yes please, and add an explicit comment in the code about why you activate this plugin at this moment precisely.

Of course, I think you can coordinate with P@t about plugins activation/deactivation to avoid c13y_upgrade being deactivated right after your activation :-)

Piwigo.org

Announcement

#1 2008-10-16 07:45:25

c13y_upgrade

Code:

#2 2008-10-16 22:54:47

Re: c13y_upgrade

#3 2008-10-17 07:55:04

Re: c13y_upgrade

#4 2008-10-20 07:44:11

Re: c13y_upgrade

#5 2008-10-22 07:16:23

Re: c13y_upgrade

#6 2008-10-22 22:30:24

Re: c13y_upgrade

rub wrote:

Board footer