Piwigo.org

You are not logged in. (Register / Login)

Announcement

#16 2017-06-10 18:58:02

windracer
Member
Location: St. Pete, FL
Registered: 2014-12-28
Posts: 151
Website

Re: Thumbnail management (creating new, deleting orphans)

Ok, got that working. Looks like I need to do the l10n messages as well so once I finish that I'll upload a new release.

Offline

 

#17 2017-06-10 19:42:12

ddtddt
Piwigo Team
Location: Quetigny - France
Registered: 2007-07-27
Posts: 6678

Re: Thumbnail management (creating new, deleting orphans)

windracer wrote:

Ok, got that working. Looks like I need to do the l10n messages as well so once I finish that I'll upload a new release.

After, you must autorise Piwigo-TranslationTeam in github ;-)


You love Piwigo so don't hesitate to participate, learn more on the "Contribute to Piwigo" page. If you don't have much time for contribution, you can also help the project with a donation.

Offline

 

#18 2017-06-11 00:57:10

windracer
Member
Location: St. Pete, FL
Registered: 2014-12-28
Posts: 151
Website

Re: Thumbnail management (creating new, deleting orphans)

After, you must autorise Piwigo-TranslationTeam in github ;-)

So many steps! ;) Ok, I'll do that too.

What's the best practice for translating l10n strings? I have a a few that append in variables so it looks like I'll have to build the string first. In other words this:

Code:

$debug_line_1 = l10n('DBG_SRC_ALBUM').$source_cat_name.' (id: '.$storage_cat_id.')';
array_push(
  $page['messages'],
  l10n($debug_line_1)
  );

instead of this:

Code:

array_push(
  $page['messages'],
  l10n('source album: '.$source_cat_name.' (id: '.$storage_cat_id.')')
  );

Rather than calling l10n the second time (in array_push) should I just use sprintf (since there's no need to re-translate since that was done beforehand)?

Last edited by windracer (2017-06-11 01:15:28)

Offline

 

#19 2017-06-13 22:29:54

windracer
Member
Location: St. Pete, FL
Registered: 2014-12-28
Posts: 151
Website

Re: Thumbnail management (creating new, deleting orphans)

eliz82 wrote:

great plugin, if you make it work with batch manager i will use it

I've added Batch Manager support in v1.0.

Offline

 

Board footer

Powered by FluxBB

github twitter facebook google+ newsletter Donate Piwigo.org © 2002-2017 · Contact